Everytime you upgrade tha datahub version, do we have to run the job datahub-restore-indices-adhoc? please 🚀

I believe you only need to run that job if you need to restore search indices, e.g. when your search/graph database data is lost. See for more details https://datahubproject.io/docs/how/restore-indices/

It strongly recommend to run

datahub-restore-indices

on upgrade, it rebuild graph index with new version of the aspect that are associated with new version datahub the same will be used for indexing and querying

I would not say that running this job is strongly recommended. This is a hammer fixup job that is intended to get instances out of a broken state. The system update job generally manages keeping your ES indices aligned with the model. Restoring all indices is time consuming and computationally expensive as it refreshes all information from the database.