<Domains> is missing `status` aspect. Is there any...
# advice-metadata-modeling
w
Domains is missing
status
aspect. Is there any reason for that? we are planning on a contribution for that 🙂
Copy code
- name: domain
    doc: A data domain within an organization.
    category: core
    keyAspect: domainKey
    aspects:
      - domainProperties
      - institutionalMemory
      - ownership
In most of (all?) other entities, deletion is implemented as soft-deletion, whereas in Domains a hard-deletion is performed (well... that's my guess giving the missing
status
aspect 😅). Also,
status
aspect is the one supporting the stateful ingestion feature in the connectors. Actually, we have a custom connector for domains and we are thinking on implementing the stateful ingestion feature and so that's when we missed the aspect.
d
maybe @big-carpet-38439 knows if it was on purpose or not 🙂
w
Hi @big-carpet-38439! Was that on purpose? If no reason, we would contribute with this feature for
Domains
🙂
r
Hey @witty-butcher-82399 the main reason that we didn't do it is because soft-deletion imlpies that the entity and relationships still live in datahub's backend, but the DataHub UI intelligently hides these domains from the entity profile, search cards, and more. (e.g. when you are viewing a dataset associated with a given domain). We just haven't prioritized the work to go through the app, audit each place that needs to be updated to support, and then supported this, since we haven't heard strong demand for this. Are you provisioning new domains using an ingestion source? Typically users do not provision new domains from ingestion, but rather just attach existing domains to entities (datasets, charts, etc) produced by the source
w
Got it... so not so easy!! 😅 Yes, domain creation is forbidden in our UI, instead we have domains defined in a repo as source of truth. Then a custom connector publish them in the catalogue. We were thinking on implementing stateful ingestion and so the requirement on Status flag.
Not much critical at this moment because domains are rarely removed.
So we were considering only if little effort 🙄