Hi guys, any chance someone from the team could have a quick look at this open PR: https://github.com/datahub-project/datahub/pull/9212. We currently need 3 custom images (mae-consumer, datahub-upgrade and gms) because of it. Many thanks!

Hey - thanks for the contribution. I think that having these as actual datahub properties would work better for the project compared to loading from system props. There's a few components that talk to ES and having them as datahub properties would allow us to hook them up to the right containers/components. For example, setting

global.elasticsearch.proxy

in a Helm chart would allows us to propagate it to every container that needs it, instead of relying on users to figure that out and set the env vars for each individual component. Ref elasticsearch options: https://github.com/datahub-project/datahub/blob/master/metadata-service/configuration/src/main/resources/application.yml#L150 Also for completeness, the

elasticsearch-setup

job would need changes too https://github.com/datahub-project/datahub/tree/master/docker/elasticsearch-setup