Hi Team. Today for a few hours the GitHub repo <co...
# contribute-code
f
Hi Team. Today for a few hours the GitHub repo confluent-docker-utils went offline, which caused the building of
kafka-setup
to fail. ๐Ÿ˜ฌ I made this PR so we no longer have this repo as a dependency, which will make the build slimmer and also more robust. Please check if it makes sense. Thanks! ๐Ÿ™
@brainy-tent-14503 I saw you fixed the
cub
usage issue by introducing a
kafka-ready.sh
script. Would it make sense to remove the pip installation of confluent-docker-utils since it seems also no longer required based on your removal of the
cub
command here? You can also check my PR above to see if it is a reasonable alternative. ๐Ÿ™‚
a
Youโ€™re probably right, those other packages are likely no longer needed. Happy to approve a PR remove those lines, otherwise will remove them the next time I need to touch that kafka-setup image.
f
@brainy-tent-14503 Thanks for the response! Sure, I opened another PR to remove those lines. Please feel free to check. ๐Ÿ™‚