Hey team :wave::skin-tone-2: I need your early fee...
# contribute-code
d
Hey team 👋🏻 I need your early feedback for my approach in here: https://github.com/datahub-project/datahub/pull/7776 Following the message above, I tried to draft what I'm thinking. I want to get your eyes before polishing and testing the new integration mostly because I'm referring to another ingestion source from an existing one and I'm not aware of any example of this approach. Could you take a brief look and comment on if going that way makes sense? If that will be the case, I'll refactor test and ask for a proper review of yours!
@careful-pilot-86309 would glad if I can also get your view on this approach, tagging since it seems like the delta ingestion is mostly made by you 💯
l
@hundreds-photographer-13496 ^
a
To circle back on this, was there a reason as to why this PR wasn't able to be merged and is it recorded somewhere so I can learn about the details?
h
Just this thread, but I'm not sure why PR was closed and not followed up on. presto_on_hive connector connects directly to underlying db of hive metastore so it might be worth giving a shot if it works for this case.
d
There was no obvious reason on our end. Due to the delays on getting a feedback for the PR, we decided to go with a custom action to detect new delta tables and enrich the metadata on hms with the one on delta using actions framework.
👍 1