Hi! I have change the acryldata/datahub-classify so that, depending on a new field 'language' entered in the yaml in the classifier part, spacy loads the module en-core-web-sm or es-core-news-sm. However, I must also change the DataHubClassifierConfig to support a new field in datahub/metadata-ingestion/src/datahub/ingestion/glossary/datahub_classifier.py. So I need to make two pull request to be accepted at the same time, how can I do this? Thanks!

Hi Olga, @hundreds-photographer-13496 might be able to help you out here- I’d say submit both and link them one to the other.

Hi Paul! Yes, this 'language' field needs to be specified in the yaml for the classifier modification to work, and to be able to use this field it must be incorporated in the DataHubClassifierConfig. Thanks!

Ah I see- this might end up being something more suited for a fork, but @big-carpet-38439 can likely speak to our acceptance policy on PR’s of this nature

The way to order this would be this: submit a PR to the classify module, we’ll review and merge it and then cut a new release. Then, you can submit the PR to the main ingestion repo and bump the required version of the classification package

Hi Harshal! I submitted a PR to the classify a few weeks ago, but there is still a workflow awaiting approval. Is there something I should do? Thanks!