I find it interesting that you have more than 1 PR...
# best-practicesh
handsome-lion-1748
08/07/2022, 2:51 PMI find it interesting that you have more than 1 PR per hour.
f
future-caravan-75733
08/07/2022, 2:52 PMWe usually deploy around 23-25 times into production a day
future-caravan-75733
08/07/2022, 2:52 PM40 devs working on the team 😊
h
handsome-lion-1748
08/07/2022, 2:55 PMWow! I'm nowhere near an experience of this scale, however I think this can be an organizational more than a performance challenge, why so many PR a day, like maybe the features the devs are working on are so trivial, and why 40 devs are working on 1 master branch, I don't have the experience to judge that is if anybody can judge.
f
future-caravan-75733
08/07/2022, 3:03 PMThe master branch is production as it is and we can't change that
future-caravan-75733
08/07/2022, 3:04 PMUsually if the change is small you can merge it without the e2e tests straight to production
future-caravan-75733
08/07/2022, 3:05 PMWe work with different squads and Feature Flags for the new features, so we have a lot small tasks under the radar hidden by a FF (and only enabled to certain users) but the code is already in production
future-caravan-75733
08/07/2022, 3:05 PMAnd we need to make sure that nothing is broken with the FF disabled for the rest of the users
future-caravan-75733
08/07/2022, 3:06 PMThat's why we need to run the e2e tests as fast as we can and merge the code quickly 😊
future-caravan-75733
08/07/2022, 3:07 PMOnce a feature is completely done, the FF code is deleted, we enabled the FF on our dynamic environments and run the tests (with the test code also updated in case something changes) and we want to see the results quickly as well
future-caravan-75733
08/07/2022, 3:08 PMAlso, the QA team itself add data-cy to the code and more tests code to the master branch (we have a Monorepo) and we also need to run the tests to make sure everything is ok with our tests code
future-caravan-75733
08/07/2022, 3:09 PM@nutritious-restaurant-91514 how do you do it on Slido? Do you have something similar than us?
future-caravan-75733
08/07/2022, 3:09 PM@handsome-lion-1748 maybe is also an organization problem but we don't know how to improve it even more. I'm happy to hear new ideas 😊
h
handsome-lion-1748
08/07/2022, 3:41 PMI'll leave it for more experienced people to share their ideas 😊
f
future-caravan-75733
08/07/2022, 3:47 PM@gray-kilobyte-89541 any advice?
g
gray-kilobyte-89541
08/07/2022, 8:31 PMSee presentations "Slide and Dice E2E tests" https://slides.com/bahmutov and perhaps "How we introduced automated ..."
f
future-caravan-75733
08/08/2022, 9:41 AMI will have a look! Thanks!