Hey folks, I want to add some functionality for wo...
# development
l
Hey folks, I want to add some functionality for working with Azure Image Galleries and the images within. Should I extend the
azure.image
resource - https://github.com/cloud-custodian/cloud-custodian/blob/main/tools/c7n_azure/c7n_azure/resources/image.py or should I create a new one called
image_gallery
or similar ?
a
Hmm, my sense from looking at those APIs is that it would make sense to have 2 new resouces: one for the gallery and one for shared images. Since the naming has shifted over time and galleries can hold applications as well as images, it might make sense to lean into their more generic "compute gallery" terminology. Maybe a resource pair of
azure.compute-gallery
and
azure.compute-gallery-image
as a child resource. (That would also leave the door open for a future
azure.compute-gallery-application
, though I haven't seen any requests for that at this point.)
👀 1
It would be slimmer to use
azure.gallery
and
azure.gallery-image
, but the chance of another gallery popping up seems high 😅
l
This was my line of thinking as well 🙂 Alright, I will give it a go and open a PR if I have something worthwhile 🙂
🙌 1
PR for Azure Compute Gallery Images https://github.com/cloud-custodian/cloud-custodian/pull/10752 🙂
Sorry for the long wait, the tests confused me a bit and I had other stuff to wrap up first 🥹