I ll happily take a nosedive into the source code but does a cfml #lucee

I'll happily take a nosedive into the source code,...

bdw429s

01/02/2023, 7:06 PM

I'll happily take a nosedive into the source code, but does anyone know off the off to their head if the

cfhttp

tag, when used with the

file

attribute, writes the downloaded file out to disk as it receives it, as opposed to buffering the entire thing in memory first and then writing it. Imagine, downloading something like an 8 Gig file, etc. You'd want it to be flushed out to disk as it comes in.

👍🏾 1

bdw429s

01/02/2023, 8:56 PM

Taking a look at this, it does not appear to work like I assumed/hoped. Lucee copies all the bytes from the http response into a ByteArrayOutputStream in memory and then copies all the bytes to disk 😕

bdw429s

01/02/2023, 8:57 PM

And based on the largest possible size of an array in Java, that appears to effectively limit cfhttp to downloading binary files larger than 2 GB

bdw429s

01/02/2023, 9:00 PM

When cfhttp is given a

file

attribute, it needs to be streaming the bytes directly to disk and not storing them anywhere. That's just terrible heap management there

bdw429s

01/02/2023, 9:03 PM

Does cfhttp still return the

fileContent

variable even when you have it save the file to disk for you? I would think it unecessary.

bdw429s

01/02/2023, 9:36 PM

Adobe at least got that part right

bdw429s

01/02/2023, 9:36 PM

Now to test and see if they buffer the file in memory or not like Lucee or go straight to disk

bdw429s

01/02/2023, 10:05 PM

Hot dang-- Adobe hit the nail on the head with this one. They stream the file right to disk and the memory graph never budges!

bdw429s

01/02/2023, 10:05 PM

Lucee just chews up all the heap in the world buffering the darn thing.

bdw429s

01/02/2023, 10:06 PM

Props to Adobe for having the right solution here. Looks like it's ticket time for Lucee!

bdw429s

01/02/2023, 10:08 PM

cc/ @dcar7191

bdw429s

01/02/2023, 10:13 PM

Wow, just found these: https://luceeserver.atlassian.net/browse/LDEV-3377 https://dev.lucee.org/t/cfhttp-stream-feature-ldev-3377/8196

bdw429s

01/02/2023, 10:13 PM

I'm quite confused why Lucee spent effort jacking around with non-standard hidden features of the cfhttp tag when all they had to do was make it work like Adobe CF already does!!!

bdw429s

01/02/2023, 10:13 PM

What on earth... 😕

bdw429s

01/02/2023, 10:14 PM

All they had to do was make it so when you specify a file/path attribute, it saves directly to disk which is already how Adobe CF does it.

bdw429s

01/02/2023, 10:24 PM

Kind of makes me wish the TAG was still around so stuff like this would caught before time and effort was invested into the wrong solution.

bdw429s

01/02/2023, 10:30 PM

https://luceeserver.atlassian.net/browse/LDEV-4357

brettpr

01/03/2023, 2:22 AM

@bdw429s - thanks for the in-depth analysis - very useful!

👍 2

Open in Slack

Previous Next