Adam Cameron
file
attribute is "Unimplemented", yet... seems to work to me.
I am worried that "Unimplemented" used in conjunction with Lucee's idiosyncratic understanding of "deprecated" might mean that all bets are off when it comes to those attributes persisting in the future.Adam Cameron
thisOldDave
07/25/2022, 4:39 PMAdam Cameron
thisOldDave
07/25/2022, 4:42 PMScott Steinbeck
07/25/2022, 4:44 PMthisOldDave
07/25/2022, 4:49 PMzackster
07/25/2022, 5:13 PMmight mean that all bets are off when it comes to those attributes persisting in the future.yeah nah, we aren't going to be removing anything, backwards compatibity is important to use. If it's implemented, and if you really care about it then perhaps file PR which updates the tag/function defintion and with test coverage?
Adam Cameron
backwards compatibity is important to useIt's utterly bewildering that you pepper "deprecated" all over the place then. But anyway. You don't really explain why it's marked as "Unimplemented". Is this a misunderstanding of this term? Or just... wrong? Ain't writing yer tests for you: whoever did the implementation shoulda done that. And they should be made to go back and backfill them now. However I will put a PR in for the docs if you clarify that "unimplemented" is just wrong. Also perhaps removing "deprecated" because clearly it isn't. It's there, it works, and it needs to work because removing it would break compat with CF for one thing. It's just wrong-headed and unhelpful to suggest it's deprecated.
zackster
07/26/2022, 8:20 AMzackster
07/26/2022, 8:29 AMzackster
07/26/2022, 8:32 AMant -DtestFilter="LDEV1234"
which will run a single any testcase matching LDEV1234Adam Cameron
you've been involved in Lucee longer than me, some of this code is over 15 years oldWell yes. However I'm not really after a history lesson or how things came to be how they are. Right here, in July 2022, I'm just trying to get clarification as to whether I should read anything into a situation where the docs say something is unimplemented when it seems like it is implemented. Asked this or a variation on it a few times now. Thusfar I've not had an on-point answer.
i think it's great you are concerned about thisI think you misunderstand: I'm not really that concerned, I'm just raising a potential shortfall / inaccuracy in the docs, and trying to clarify what they should say. Am I to take from all this that the answer to this question:
You don't really explain why it's marked as "Unimplemented". Is this a misunderstanding of this term? Or just... wrong?is "yes, it's just wrong"? <----- this is all I'm really interested in.
thisOldDave
07/26/2022, 10:01 AM<attribute>
<type>string</type>
<name>text</name>
<required>false</required>
<rtexprvalue>true</rtexprvalue>
<description>an exception to log.</description>
</attribute>
<attribute>
<type>any</type>
<name>exception</name>
<required>false</required>
<rtexprvalue>true</rtexprvalue>
<description>The message text to log.</description>
</attribute>
zackster
07/28/2022, 7:57 AMAdam Cameron
is "yes, it's just wrong"? <----- this is all I'm really interested in.I'm sure than in no more than a few days, we'll be there. --- In other news it seems odd that in the docs to something that one has to explicitly say "it's implemented" because the default behaviour is "no it's not". Exactly how much time does one spend documenting stuff that's not implemented, for that to be the most sensible default? [weird]
zackster
07/28/2022, 9:26 AMAdam Cameron
<cfif local.arg.status neq "implemented">
<cfset arrayAppend(unimplementedArgs, local.arg)>
<cfcontinue>
</cfif>
Cos that does the exact opposite of what you said, doesn't it?zackster
07/28/2022, 10:25 AMzackster
07/28/2022, 10:25 AMAdam Cameron
Adam Cameron
https://i2.paste.pics/b159f79eaa334274ee1b7f90c1354183.png▾
Adam Cameron
Adam Cameron
the current rules definition drops anything without the implemented status into Unimplemented
it more or less defaults to implemented if it's not specifiedWhat am I missing?
zackster
07/29/2022, 6:29 AM