I have the following try catch block but still get this erro cfml #cfml-beginners

I have the following try/catch block, but still ge...

epipko

02/07/2022, 5:21 PM

I have the following try/catch block, but still get this error: Element QUERYERROR is undefined in CFCATCH. What am I not doing to catch it?

Copy code

<CFTRY>
	<cfstoredproc procedure="UPDATE_PKG.MAIN_P" datasource="#REQUEST.prod#">
		<cfprocparam type="In" value=#FORM.sales_order_number# cfsqltype="CF_SQL_INTEGER">
		<cfprocparam type="In" value=#FORM.division_id# cfsqltype="CF_SQL_VARCHAR">
	</cfstoredproc>
	
	<cfoutput>
		<h3 align="left">Success</h3>
		<p></p><a href="#CGI.http_referer#">Go Back</a>
	</cfoutput>	

	<CFCATCH TYPE = "Database">
		<cfoutput>   
			Something went wrong :-( Contact your system administrator<br />
			#cfcatch.queryError#			
		</cfoutput>
 	</CFCATCH>
</CFTRY>

Myka Forrest

02/07/2022, 5:23 PM

Try dumping your

cfcatch

to see what keys are available.

Myka Forrest

02/07/2022, 5:25 PM

Also, this idea may be a little out there, but perhaps the

type

attribute is case-sensitive?

aliaspooryorik

02/07/2022, 5:27 PM

Yeah, not all keys in

cfcatch

always exist. So your code is erroring when it runs, but then inside the error handling (the

cfcatch

block) you are referencing something that doesn't exist.

aliaspooryorik

02/07/2022, 5:29 PM

Also - I wouldn't output the error information as you are exposing information about your applications / database which hackers could use to exploit it. You should log the error and put out a generic "sorry" message to the end user.

epipko

02/07/2022, 5:46 PM

Thanks for replies. It looks like TYPE needs to be "database" and dump revealed no queryError in it. I guess the error happened before sql was passed into a database. Should I use TYPE="any"? Will it work with database errors?

Myka Forrest

02/07/2022, 5:47 PM

If you were planning to handle errors differently, I might use the type attribute, but yours appears to be generic ("something went wrong"), so I would use "any" (which I believe is the default anyway).

👆 2

epipko

02/07/2022, 5:52 PM

I think I just answered my own question by entering 1/0 into my stored proc. Type="any" returned "Error: Error Executing Database Query.", but "database" returned much more useful data: "ORA-01476: divisor is equal to zero"

epipko

02/07/2022, 5:54 PM

So, how do I combine the two? I need to catch errors with type="any" before sql is passed into a database, but would like to have detailed error msg with type="database" when proc is running.

aliaspooryorik

02/07/2022, 5:56 PM

You can have multiple catch types. For example:

aliaspooryorik

02/07/2022, 5:58 PM

Copy code

<cftry>
  <!--- run some code --->
  <cfcatch type="database">
    <!--- handle a database error --->
  </cfcatch>
  <cfcatch type="any">
    <!--- handle any other type of error --->
  </cfcatch>
</cftry>

👍 1

👍🏼 1

epipko

02/07/2022, 6:05 PM

Thank you both!

3 Views

Open in Slack

Previous Next