http://coldfusion.com logo
Join Slack
Powered by
Anyone having issues with ColdBox v6.6.1 (released...
# box-products
d
Anyone having issues with ColdBox v6.6.1 (released 2/17). Our login process, which uses cbsecurity, breaks on this new version. All fine on 6.6.0. Here is the error. The first file it references in the stack trace is location.cfm, which doesn’t exist in our project or within the Coldbox folders, as far as I can tell. Thoughts?
Not sure what this references, but this ticket included in the 6.6.1 release sounds suspicious? https://ortussolutions.atlassian.net/browse/COLDBOX-1091
b
Interesting
So the old code had a check that ONLY relocated if the status code was something OTHER than 0
But that if statement is gone now
d
It looks like it is a problem in cbinertia now.
b
The file also defaults the status code to 302 and I assume Luis thought there would be no way the status code would ever be 0
Can you trace where the relocate call is coming from and where it's being set to 0?
d
the relocate in cbinertia defaults to 0.
b
ahh, that would be a problem!
Do you know what 0 is meant to mean?
🤷‍♂️ 1
I can't imagine why that would ever be used unless it was supposed to have some semantic meaning
s
it looks like 200
b
Like, "haha, just kidding, don't actually relocate!"
d
b
Hmm, I suppose @elpete or whoever wrote that would need to explain what they were intending 0 to mean if it was left as-is
Was 0 supposed to default to something else, or not really relocate?
Obviously @lmajano didn't realize there would be code out there explicitly passing that
oh, I see- re-reading the original code. It would still relocate, it would simply not pass a status code to the actual cflocation tag, allowing the CF engine to default it
Put in a ticket please
d
To ColdBox or cbinertia?
b
coldbox
👌 1
That part of ColdBox needs to fix the regression. There are libraries out there depending on the fact that a status code explicitly set to 0 means to allow the CF engine to default it. or just default it manually to 302
Luis removed that 0 handling from ColdBox thinking no one OUTSIDE of ColdBox was using it!
cc @lmajano
d
Thanks @bdw429s.
b
Thanks. I have pointed the ticket out to Luis internally just now as well
Feel free to send a pull- it's probably as simple as just putting that if statement back in
Or something akin to
Copy code
if ( arguments.statusCode eq 0 ) {
  arguments.statusCode = 302;
}
above the redirect
d
How do releases work for ColdBox? When would v6.6.2 be cut with this?
e
cbInertia had that to match ColdBox. It's decorating the method and wasn't meant to change that part. That's why it's 
0
.
We'll update cbInertia as well, but we were just trying to be a good ColdBox citizen. ;-)
😂 1
b
@danmurphy the fix will be available on the snapshot builds as soon as Luis commits it. The next stable release will be whenever Luis feels like it 😉 but we aim to release every month or so with our main products.
👍 1
6 Views
Open in Slack
PreviousNext
Powered by