Not sure if this is Lucee or Coldbox Starting in 5 3 9 95 up cfml #lucee

Not sure if this is Lucee or Coldbox? Starting in ...

leftbower

03/15/2022, 8:17 PM

Not sure if this is Lucee or Coldbox? Starting in 5.3.9.95 (up through 108), we are having trouble displaying PDFs in browser. It's tough to get a stacktrace, but getting a

java.lang.NullPointerException

in Coldbox here:

coldbox\system\core\conversion\DataMarshaller.cfc

This is in a simple handler that just does:

Copy code

var theBinary = fileReadBinary( file );
event.renderData( data=theBinary, type="PDF" );

Has anyone else experienced same? Dropping back to 5.3.9.92 fixes.

bdw429s

03/15/2022, 8:18 PM

@leftbower Need to see the full java stack trace

bdw429s

03/15/2022, 8:18 PM

or at least the part of the java stack trace above the top .cfc line

bdw429s

03/15/2022, 8:18 PM

There are some PDF fixes, so this may be a regression in cfdocument

dswitzer

03/15/2022, 8:23 PM

I do know there were some changes with binary detection in a recent ticket, so that could be the root cause.

leftbower

03/15/2022, 8:30 PM

FWIW, not using cfdocument, just the renderData method above. The PDF opens fine on its own nor is it generated by the app

bdw429s

03/15/2022, 8:30 PM

@leftbower render data uses cfdocument to render PDFs

bdw429s

03/15/2022, 8:30 PM

Instead of guessing what is being called, provide the stack trace and then we'll know 🙂

leftbower

03/15/2022, 8:51 PM

Copy code

lucee.runtime.exp.NativeException: java.lang.NullPointerException at lucee.runtime.tag.Content._doStartTag(Content.java:185) at lucee.runtime.tag.Content.doStartTag(Content.java:156) at system.core.conversion.datamarshaller_cfc$cf.udfCall(/coldbox/system/core/conversion/DataMarshaller.cfc:151) at lucee.runtime.type.UDFImpl.implementation(UDFImpl.java:112) at lucee.runtime.type.UDFImpl._call(UDFImpl.java:350) at lucee.runtime.type.UDFImpl.callWithNamedValues(UDFImpl.java:213) at lucee.runtime.ComponentImpl._call(ComponentImpl.java:661) at lucee.runtime.ComponentImpl._call(ComponentImpl.java:582) at lucee.runtime.ComponentImpl.callWithNamedValues(ComponentImpl.java:1948) at lucee.runtime.util.VariableUtilImpl.callFunctionWithNamedValues(VariableUtilImpl.java:866) at lucee.runtime.PageContextImpl.getFunctionWithNamedValues(PageContextImpl.java:1768) at system.bootstrap_cfc$cf.udfCall2(/coldbox/system/Bootstrap.cfc:742) at system.bootstrap_cfc$cf.udfCall(/coldbox/system/Bootstrap.cfc) at lucee.runtime.type.UDFImpl.implementation(UDFImpl.java:112) at lucee.runtime.type.UDFImpl._call(UDFImpl.java:350) at lucee.runtime.type.UDFImpl.callWithNamedValues(UDFImpl.java:213) at lucee.runtime.type.scope.UndefinedImpl.callWithNamedValues(UndefinedImpl.java:804) at lucee.runtime.util.VariableUtilImpl.callFunctionWithNamedValues(VariableUtilImpl.java:866) at lucee.runtime.PageContextImpl.getFunctionWithNamedValues(PageContextImpl.java:1768) at system.bootstrap_cfc$cf.udfCall1(/coldbox/system/Bootstrap.cfc:394) at system.bootstrap_cfc$cf.udfCall(/coldbox/system/Bootstrap.cfc) at lucee.runtime.type.UDFImpl.implementation(UDFImpl.java:112) at lucee.runtime.type.UDFImpl._call(UDFImpl.java:350) at lucee.runtime.type.UDFImpl.call(UDFImpl.java:223) at lucee.runtime.type.scope.UndefinedImpl.call(UndefinedImpl.java:786) at lucee.runtime.util.VariableUtilImpl.callFunctionWithoutNamedValues(VariableUtilImpl.java:787) at lucee.runtime.PageContextImpl.getFunction(PageContextImpl.java:1749) at system.bootstrap_cfc$cf.udfCall1(/coldbox/system/Bootstrap.cfc:519) at system.bootstrap_cfc$cf.udfCall(/coldbox/system/Bootstrap.cfc) at lucee.runtime.type.UDFImpl.implementation(UDFImpl.java:112) at lucee.runtime.type.UDFImpl._call(UDFImpl.java:350) at lucee.runtime.type.UDFImpl.call(UDFImpl.java:223) at lucee.runtime.ComponentImpl._call(ComponentImpl.java:660) at lucee.runtime.ComponentImpl._call(ComponentImpl.java:582) at lucee.runtime.ComponentImpl.call(ComponentImpl.java:1929) at lucee.runtime.util.VariableUtilImpl.callFunctionWithoutNamedValues(VariableUtilImpl.java:787) at lucee.runtime.PageContextImpl.getFunction(PageContextImpl.java:1749) at application_cfc$cf$6.udfCall(/Application.cfc:34) at lucee.runtime.type.UDFImpl.implementation(UDFImpl.java:112) at lucee.runtime.type.UDFImpl._call(UDFImpl.java:350) at lucee.runtime.type.UDFImpl.call(UDFImpl.java:223) at lucee.runtime.ComponentImpl._call(ComponentImpl.java:660) at lucee.runtime.ComponentImpl._call(ComponentImpl.java:582) at lucee.runtime.ComponentImpl.call(ComponentImpl.java:1929) at lucee.runtime.listener.ModernAppListener.call(ModernAppListener.java:437) at lucee.runtime.listener.ModernAppListener._onRequest(ModernAppListener.java:133) at lucee.runtime.listener.MixedAppListener.onRequest(MixedAppListener.java:44) at lucee.runtime.PageContextImpl.execute(PageContextImpl.java:2462) at lucee.runtime.PageContextImpl._execute(PageContextImpl.java:2452) at lucee.runtime.PageContextImpl.executeCFML(PageContextImpl.java:2423) at lucee.runtime.engine.Request.exe(Request.java:45) at lucee.runtime.engine.CFMLEngineImpl._service(CFMLEngineImpl.java:1194) at lucee.runtime.engine.CFMLEngineImpl.serviceCFML(CFMLEngineImpl.java:1140) at lucee.loader.engine.CFMLEngineWrapper.serviceCFML(CFMLEngineWrapper.java:97) at lucee.loader.servlet.CFMLServlet.service(CFMLServlet.java:51) at javax.servlet.http.HttpServlet.service(HttpServlet.java:590) at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74) at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129) at org.cfmlprojects.regexpathinfofilter.RegexPathInfoFilter.doFilter(RegexPathInfoFilter.java:47) at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131) at io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84) at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62) at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68) at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36) at io.undertow.servlet.handlers.RedirectDirHandler.handleRequest(RedirectDirHandler.java:68) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:262) at io.undertow.servlet.handlers.ServletInitialHandler.dispatchToPath(ServletInitialHandler.java:187) at io.undertow.servlet.spec.RequestDispatcherImpl.forwardImpl(RequestDispatcherImpl.java:227) at io.undertow.servlet.spec.RequestDispatcherImpl.forwardImplSetup(RequestDispatcherImpl.java:149) at io.undertow.servlet.spec.RequestDispatcherImpl.forward(RequestDispatcherImpl.java:111) at org.cfmlprojects.regexpathinfofilter.RegexPathInfoFilter.doFilter(RegexPathInfoFilter.java:45) at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131) at io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84) at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62) at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68) at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36) at io.undertow.servlet.handlers.RedirectDirHandler.handleRequest(RedirectDirHandler.java:68) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:262) at io.undertow.servlet.handlers.ServletInitialHandler.dispatchToPath(ServletInitialHandler.java:187) at io.undertow.servlet.spec.RequestDispatcherImpl.forwardImpl(RequestDispatcherImpl.java:227) at io.undertow.servlet.spec.RequestDispatcherImpl.forwardImplSetup(RequestDispatcherImpl.java:149) at io.undertow.servlet.spec.RequestDispatcherImpl.forward(RequestDispatcherImpl.java:111) at org.tuckey.web.filters.urlrewrite.NormalRewrittenUrl.doRewrite(NormalRewrittenUrl.java:215) at org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:171) at org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:145) at org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:92) at org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:405) at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131) at io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84) at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62) at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68) at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36) at io.undertow.servlet.handlers.RedirectDirHandler.handleRequest(RedirectDirHandler.java:68) at io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:117) at io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46) at io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64) at io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60) at io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77) at io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at runwar.Server$1.handleRequest(Server.java:510) at io.undertow.servlet.handlers.SendErrorPageHandler.handleRequest(SendErrorPageHandler.java:52) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:280) at io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:79) at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:134) at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:131) at io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48) at io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43) at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:260) at io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:79) at io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:100) at io.undertow.server.Connectors.executeRootHandler(Connectors.java:387) at io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:852) at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:2019) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1558) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1449) at org.xnio.XnioWorker$WorkerThreadFactory$1$1.run(XnioWorker.java:1280) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.lang.NullPointerException ... 129 more

bdw429s

03/15/2022, 9:01 PM

@leftbower

Copy code

lucee.runtime.exp.NativeException: java.lang.NullPointerException 
 atlucee.runtime.tag.Content._doStartTag(Content.java:185) 
 atlucee.runtime.tag.Content.doStartTag(Content.java:156) 
 atsystem.core.conversion.datamarshaller_cfc$cf.udfCall(/coldbox/system/core/conversion/DataMarshaller.cfc:151)

Looks like the error is coming from the CFContent tag https://github.com/ColdBox/coldbox-platform/blob/development/system/core/conversion/DataMarshaller.cfc#L151

bdw429s

03/15/2022, 9:01 PM

The CFDocument tag is being used in the marshaller to create PDFs, but it would appear that part worked and it errored later on

bdw429s

03/15/2022, 9:03 PM

The line of Java code that is erroring has changed recently and is this

Copy code

if (!HTTPUtil.isTextMimeType(type) == Boolean.TRUE) {

bdw429s

03/15/2022, 9:04 PM

I don't see an import for

Boolean

in that class, but I actually would expect just not to compile 🤔

bdw429s

03/15/2022, 9:04 PM

Unless

Boolean

doesn't need imported

bdw429s

03/15/2022, 9:04 PM

The only other thing that could be null would be HTTPUtil which is a static import to the class

bdw429s

03/15/2022, 9:07 PM

that line of code was changed 2 weeks ago for LDEV-3679

bdw429s

03/15/2022, 9:08 PM

https://github.com/Ortus-Solutions/Lucee/commit/a3d8c6109472da47a4e1444cd4eacd676f5e3194

bdw429s

03/15/2022, 9:11 PM

I think I see the issue https://github.com/Ortus-Solutions/Lucee/commit/a3d8c6109472da47a4e1444cd4eacd676f5e3194#diff-a6e8cd22c6f8b90e3933d61[…]68ad35668df92cbff711ac87R639

bdw429s

03/15/2022, 9:11 PM

MIcha changed the

isTextMimeType()

to return a

Boolean

class instance instead of a

boolean

primitive (lowercase)

bdw429s

03/15/2022, 9:12 PM

Primitves can't be null, but class instances can

bdw429s

03/15/2022, 9:12 PM

So the new code path he added to return a

null

gives us an

NPE

when he checks the value of it

bdw429s

03/15/2022, 9:12 PM

@zackster ☝️ 5.3.9 regression

bdw429s

03/15/2022, 9:12 PM

@leftbower

bdw429s

03/15/2022, 9:13 PM

If Micha is going to return a

Boolean

type from that method and sometimes that return will be null, every place that checks the return value of that method needs to check for

null

AS WELL AS a boolean value

bdw429s

03/15/2022, 9:14 PM

My guess is the mime type ColdBox is passing to the CFContent tag isn't one Lucee recognizes

Adam Cameron

03/15/2022, 9:31 PM

MIcha changed the
isTextMimeType()
to return a
Boolean
class instance instead of a
boolean
primitive (lowercase)

Amazing his tests didn't flag that up before he made the change [cough]

bdw429s

03/15/2022, 9:52 PM

heh

bdw429s

03/15/2022, 9:52 PM

I can reproduce with this

Copy code

content type="foobar";

bdw429s

03/15/2022, 9:57 PM

I created a ticket since I did the research and was familiar with the issue. https://luceeserver.atlassian.net/browse/LDEV-3910

leftbower

03/15/2022, 10:03 PM

thx for that thorough follow through!

👍 3

zackster

03/15/2022, 11:27 PM

snarky comments about test cases are extremely welcome via constructive PRs! HELP WANTED and REALLY APPRECIATED https://github.com/lucee/Lucee/commit/4494de11f281c9245fb8916b8744ca69c41d82ec

zackster

03/16/2022, 1:11 AM

Obviously there's plenty more cfcontent functionality which needs tests...

steveduke

03/16/2022, 1:14 PM

we see something very similar using this test:

Copy code

<cfdocument format="pdf" name="pdf_test">
	<html style="height: 99%">
	<body style="font-family: Helvetica, Arial, sans-serif; height: 90%">
		<div>hello</div>
	</body>
	</html>
</cfdocument>

<cfcontent type="application/pdf" variable="#pdf_test#">

this is our basic setup:

Copy code

System Information
Version	Lucee 5.3.9.108-RC
Version Name	Gelert
Release date	Mar 14, 2022	
Servlet Container	Apache Tomcat/8.5.61
Java	11.0.10 (AdoptOpenJDK) 64bit
OS	Windows Server 2016 (10.0) 64bit
Architecture	64bit

zackster

03/18/2022, 3:28 PM

fixed in 5.3.9.109

👍 1

zackster

03/18/2022, 3:31 PM

there's a problem with _internalRequest which prevents us from adding test cases using cfcontent https://luceeserver.atlassian.net/browse/LDEV-3761

steveduke

03/18/2022, 4:31 PM

I can confirm 5.3.9.109 works for us ! Thanks @zackster

zackster

03/18/2022, 4:31 PM

awesome

Open in Slack

Previous Next