thanks <@U3K7R5W75> for writing this up <https://d...
# lucee
z
thanks @pothys-mitrahsoft for writing this up https://docs.lucee.org/guides/cookbooks/mail_listeners.html
a
Is this odd?
Note: Mail listener only triggered when the mail sending as async
Ought not the event the listener is attached to be fired... if the
<cfmail>
tag it's attached to is called. Irrespective of when the mail message from the
<cfmail>
tag is sent?
Also... might need a grammar check on that doc, based on that sentence.
It's a good first draft though.
(actually yeah, that doc probably needed a proofread before it went up, having scrutinised it more closely... I'll look at see what I need to do to pop a revision pull req in...)
z
yeah, it's easier to throw up and then edit, i did a quick tweak, but it's been a long day
a
On the case. Will have a pull req in 10min.
Just to be clear, I presume it can be any struct returned from the
before
listener, not a "modified arguments struct"? IE: yer returning a struct, not modifying the arguments struct reference?
Because the wording currently is a bit vague.
Also: does the struct need to return all the keys, or will a subset act as overrides for those parameters, and other settings will remain as defined on the original tag?
Ugh ended up being two pull requests. 1299 should be applied after 1300, sorry. I spotted some further problems when I was looking at the commit for 1299 and went back and fixed them, but when I submitted it made anew commit (unsurprisingly).
z
Thanks mate, I'll merge em now
1299 has conflicts...
a
Lemme check
sorry for the balls-up with the commits
Ha after that, the only change is the insertion of a previously-missing colon. All resolved though.