anyone can guide what parameters i am missing here