I am running into a upgrading issue. In Mura 7 we ...
# masacms
j
I am running into a upgrading issue. In Mura 7 we have attributes in an Extended attribute set where we use an optionlist. In the
old
Mura we had
[mura]$.getNewsOptionLabelList()[/mura]
which would run
getNewsOptionLabelList()
from the Contentrenderer to build an option list in a selectbox. In Masa 7.2 this is not working and we only see
[mura]$.getNewsOptionLabelList()[/mura]
in a single option of the select box. I have tried replacing both
[mura]
and
$
with
m
and tried
[m]
, but no luck What is the correct syntax to run
getNewsOptionLabelList()
from the Contentrenderer
s
Hi, we have the same issue, but after upgrading to 7.4.6, where a lot of security issues were fixed. Only one option is shown in extended attributes and none of the others are rendered. And in the Admin we also get the code for the extended attribute shown, instead of the rendered extended attribute. I thought it was due to the security fixes, excluding all evaluates and eval and whatnot, but we're still not sure what is happening there. Will get back to you if we figure this one out...
👍 1
j
Maybe @guustnieuwenhuis knows?
g
We’ll look into this asap.
👍🏻 1
👍🏼 1
s
Here's what we see in the Admin, as an example:
j
Same here
Some more info
s
Our setup
j
What I would expect
g
Can you guys send us an export of the Extended attribute to guust@wearenorth.eu?
✔️ 2
s
Hi @guustnieuwenhuis your fix (pull request) does not seem to solve the issue. It still just shows the code of the mura-tag instead of rendering the mura-tag. Misja Helsloot will provide you directly with our findings.
j
Any news regarding developments on this "bug"?
Hi @guustnieuwenhuis any news regarding this issue?
Ok, so I dove into this myself. Turns out I was missing the setting
enabledynamicoutput
in my
settings.ini.cfm
. Because of that the setting defaulted to
false
. Because of this, in
core\mura\content\contentRenderer.cfc
on line
2706
the
if
statement matched and the exact string (being a mura tag with a function call) was returned. Adding
enabledynamiccontent=true
to my
settings.ini.cfm
fixed it. I don't think I have seen this in the
breaking changes
anywhere.
I think the
if
statement should be expanded with a check for
enablemuratag
to prevent security risks? https://docs.masacms.com/getting-started/configuration/configuration-file/#enablemuratag
s
We're testing your find now, to see if it also works for us. It is a core update if I'm not mistaken, so MASA CMS will have to take this in as PR I guess, if we want it persisted?
j
Well, a change in settings.ini.cfm is an environment setting, so I don't think this should be committed to the core code?
s
ah, ok!