Actually, I think the checkbox name is:
```reques...
# luceec
Charles Robertson
07/04/2023, 12:09 PMActually, I think the checkbox name is:
Copy code
requestExclusivez
zackster
07/04/2023, 12:47 PMthread plz
zackster
07/04/2023, 12:48 PM👍 1
c
Charles Robertson
07/04/2023, 1:18 PM@bdw429s I actually saw this property in:
https://github.com/Ortus-Solutions/commandbox-cfconfig/blob/master/commands/cfconfig/datasource/save.cfc
Copy code
requestExclusiveCharles Robertson
07/04/2023, 1:29 PMThanks. I can see that it will available in Lucee 6 🙂
Charles Robertson
07/04/2023, 1:29 PMAre there any plans to add it to 5.4?
z
zackster
07/04/2023, 1:29 PMnope
👍 1
zackster
07/04/2023, 1:30 PMwhich ticket in jira?
c
Charles Robertson
07/04/2023, 1:31 PMActually, I can see it in 5.4:
https://github.com/lucee/Lucee/blob/5.4/core/src/main/cfml/context/admin/services.datasource.create.cfm
z
zackster
07/04/2023, 1:31 PMthat's what i thought
c
Charles Robertson
07/04/2023, 1:31 PM😂
Charles Robertson
07/04/2023, 1:31 PMSorry
Charles Robertson
07/04/2023, 1:38 PMHmmm. Well, when I try and add it using the method version of
Copy code
<cfadmin action="updateDatasource" /> Copy code
variables.adm = new Administrator("server", variables.adminpassword);
variables.adm.updateDatasource(
type=variables.datasource.dbdriver,
name=variables.key,
newName=variables.key,
host=variables.datasource.host,
port=variables.datasource.port,
database=variables.datasource.database,
username=variables.datasource.username,
password=variables.datasource.password,
requestExclusive=true
);z
zackster
07/04/2023, 1:44 PMwanna submit a patch, administraor.cfc is cfml
c
Charles Robertson
07/04/2023, 1:50 PMSorry, do you want me to submit a patch?
Charles Robertson
07/04/2023, 1:56 PMI don't think I have ever submitted a patch?
And to be honest, it looks like an issue with the Java, not the CFML?
Charles Robertson
07/04/2023, 1:57 PMBy the way did you mean:
https://github.com/lucee/Lucee/blob/5.3.9/core/src/main/cfml/context/Admin.cfc
Charles Robertson
07/04/2023, 2:16 PMCharles Robertson
07/04/2023, 2:18 PMOK. I can now see that:
Copy code
requestExclusive Copy code
public void function updateDatasource(){}Charles Robertson
07/05/2023, 10:22 AMIf I create a ticket for this, can we add this to 5.4? We have tested the fix and it works...
z
zackster
07/05/2023, 10:54 AMsure
👍 1
c
Charles Robertson
07/05/2023, 11:08 AMShould I make a FORK of:
https://github.com/lucee/Lucee/tree/5.4
And then:
Create a feature branch/ticket and send you a PR?
Charles Robertson
07/05/2023, 11:10 AMOr can I just clone:
https://github.com/lucee/Lucee.git
And create a branch/ticket/PR
z
zackster
07/05/2023, 11:10 AMfork and follow this guide https://docs.lucee.org/guides/working-with-source/building-and-testing-extensions.html#submitting-pull-requests-prs
👍 1
c
Charles Robertson
07/05/2023, 12:46 PMI have got some weird check errors on:
https://github.com/lucee/Lucee/pull/2163
z
zackster
07/05/2023, 1:03 PMyeah know issues, @pothys-mitrahsoft is looking into the http ones
👍 2
c
Charles Robertson
07/05/2023, 2:42 PMHi Zack
Do you know roughly how many concurrent datasource connections, Lucee can handle?
My team want to switch this setting on, but I am concerned that it will limit how many DSNs our system will be able to handle.
We have 600 DSNs
Copy code
Exclusive connections for request
If set to true, the connections of this datasource are exclusive to one request, guaranteeing that you always have the same connection to the datasource for the request. Keep in mind that this limits the maximum possible concurrent requests to the maximum possible datasource connections and can cause a lot more open connections. Only use the requestExclusive setting when it is absolutely necessary to always have the same connection within a request, for example when your connection has set a specific state.z
zackster
07/05/2023, 3:01 PMNo idea but I would avoid so many DSNs myself, seems like you're asking for trouble and that setting will just exacerbate it
zackster
07/05/2023, 3:01 PMLoad test to find your answer
👍 1