Having some trouble with commandbox-actions runnin...
# box-productsb
bhartsfield
06/12/2023, 2:01 PMHaving some trouble with commandbox-actions running cfformat check and failing on all files where, locally, all files pass. I've confirmed that the action is in the right directory and using the correct .cfformat.json rules but cannot figure out why they all fail in the action.
The entire workflow is just this...
Copy code
on: [push]
jobs:
build:
name: CFML Format and lint checks
runs-on: ubuntu-latest
steps:
- name: Check out repository code
uses: actions/checkout@v3
- name: Linter/Format Checks
uses: Ortus-Solutions/commandbox-action@v1.0.3
with:
cmd: cd /github/workspace/app && run-script format:check && run-script linterbhartsfield
06/12/2023, 2:02 PMMy package script for format:check is...
"format:check":"cfformat check handlers,includes,interceptors,models,tests/**.cfc,ModuleConfig.cfc",bhartsfield
06/12/2023, 2:02 PMThe cflint check works fine in the action
bhartsfield
06/12/2023, 2:09 PMactions is running CommandBox 5.8.0+00695 (don't tell Brad but that is also the version I am running locally)
b
bdw429s
06/12/2023, 3:24 PMWhat's the build output?
bdw429s
06/12/2023, 3:25 PMI would assume some of your source files are not formatted correctly
bdw429s
06/12/2023, 3:25 PMThe check command returns a failing exit code if the files aren't formatted.
b
bhartsfield
06/12/2023, 3:26 PMThe output is the expected result when files are NOT formatted
The following files do not match the cfformat rules:
<list of ALL files>
Please format the files using the
--overwritebhartsfield
06/12/2023, 3:27 PMagain though, the same cfformat command running locally using the same .cfformat.json file says the fiels are all already formatted correctly.
bhartsfield
06/12/2023, 3:27 PM(and same commandbox version)
bhartsfield
06/12/2023, 3:37 PMgot it to output the expected formatted results of one of the files to compare and it is complaining about some spacing that it doesn't complain about locally (again with the same .cfformat.json rules)
Copy code
"loadPaths" : [
"#expandPath( ".\modules_app\fileService\lib" )#",
"#expandPath( ".\modules_app\parsingService\lib" )#"
],bhartsfield
06/12/2023, 3:39 PMactually, it SHOULDN'T be complaining about it since it lines up with a few more keys (not that it matters right now... just trying to figure out why there are different results)
Copy code
this["javaSettings"] = {
"loadPaths" : [
"#expandPath( ".\modules_app\fileService\lib" )#",
"#expandPath( ".\modules_app\parsingService\lib" )#"
],
"loadCFMLClassPath": true,
"reloadOnChange" : true,
"watchInterval" : 100,
"watchExtensions" : "jar,class"
};bhartsfield
06/12/2023, 3:54 PMran install for cfformat 0.19.0 to match my local version and STILL a different result. Windows vs Ubuntu maybe ¯\_(ツ)_/¯
I'll have to test my stuff in ubuntu I guess.
bhartsfield
06/12/2023, 4:07 PMcheck is failing on ubuntu for me so must be a windows/ubuntu difference... which is gonna suck since these guys are writing everything on Windows.
bhartsfield
06/12/2023, 4:22 PMUbuntu cfformat wants to convert all indent tabs to spaces... that's (mostly) why it's complaining on all files
b
bdw429s
06/12/2023, 4:37 PMYeah, I would expect this is a whitespace issue.
bdw429s
06/12/2023, 4:38 PMRegardless, the question was really about cfformat and not CommandBox. I didn't write and don't maintain cfformat. You can reach out to John Berquist on the Github issue tracker for cfformat questions (or ping him here)
👍 1
bdw429s
06/12/2023, 4:38 PMIf you want to be loosey goosey on whitespace, you can prolly just remove that rule
b
bhartsfield
06/12/2023, 4:39 PMyeah, ubuntu seems to be ignoring the tab_indent: true setting. I was thinking about just turning it off and reformatting everything
bhartsfield
06/12/2023, 4:39 PMthanks for looking with me