:wave: Hola folks, I think the new v1.8.1 has com...
# docker
k
👋 Hola folks, I think the new v1.8.1 has compatibility issue.
Copy code
$ turbo run build --scope="@calcom/web" --include-dependencies
/cal_com_app/node_modules/turbo/bin/turbo:13
    throw e;
    ^

Error: Cannot find module 'turbo'
Require stack:
- /cal_com_app/node_modules/turbo/node-platform.js
- /cal_com_app/node_modules/turbo/bin/turbo
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.resolve (node:internal/modules/cjs/helpers:108:19)
    at downloadedBinPath (/cal_com_app/node_modules/turbo/node-platform.js:56:44)
    at generateBinPath (/cal_com_app/node_modules/turbo/node-platform.js:79:15)
    at Object.<anonymous> (/cal_com_app/node_modules/turbo/bin/turbo:7:5)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/cal_com_app/node_modules/turbo/node-platform.js',
    '/cal_com_app/node_modules/turbo/bin/turbo'
  ]
}
error Command failed with exit code 1.
h
It looks like, turbo binary is missing. May be try running yarn again
k
bin is available.
running directly on my mac cli works. However, it doesnt work inside docker with
FROM node:16
🤔 1
h
Then it's probably not properly installed. Run
yarn clean
in root and try
yarn install
again
So it's a docker only problem?
k
message has been deleted
si, only inside. Very weird.
I tried to install turbo global inside docker as well.
h
Don't have much experience with docker, I would let others from the community reply.
k
Appreciate that @Hariom Balhara
Trying some tricks here/
p
weird. maybe @Colin - Krumware knows whats up
c
Is that happening in your build or are you trying to execute that inside the container?
k
docker build step
c
👍I'll be at my office in a few mins to help
k
No rush, Pls take ur time.
I am trying my tricks here. Hopefully will get more insight
c
I'll pull latest submodule and ensure it builds on my end to help see if it's a layer cache issue
k
I am using
--no-cache
already
c
👍
at desk, building now
do you have a Step #?
c
that step just passed on my end, prior to submodule update
Updated submodule built for me as well
trying with no-cache
@Krishna Raj are you on ARM or x86/64?
k
Intertesting.
I am on x86/64
👍 1
Copy code
RUN ./node_modules/turbo/bin/turbo --version
 ---> Running in 11a3ce7b5775
/cal_com_app/node_modules/turbo/bin/turbo:13
    throw e;
    ^

Error: Cannot find module 'turbo'
Require stack:
- /cal_com_app/node_modules/turbo/node-platform.js
- /cal_com_app/node_modules/turbo/bin/turbo
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.resolve (node:internal/modules/cjs/helpers:108:19)
    at downloadedBinPath (/cal_com_app/node_modules/turbo/node-platform.js:56:44)
    at generateBinPath (/cal_com_app/node_modules/turbo/node-platform.js:79:15)
    at Object.<anonymous> (/cal_com_app/node_modules/turbo/bin/turbo:7:5)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) {
  code: 'MODULE_NOT_FOUND',
I tried this custom command to find turbo version, its just fails.
So weird
c
your local node_modules folder shouldn't be overriding the one in the build, but just for sanity, is there a node_modules folder in your calcom folder?
also, is your submodule using the
calcom
folder name, or the old
calendso
?
(if calendso it should fail for missing file prior, but asking for sanity)
k
a moment to check
@Colin - Krumware Thanks a bunch for trying to help me on this in short notice. I think my problem is the build runs with all the packges as scope. I must only be web
i will try fix the issue on my end.
c
that would make sense. It's possible to run the web build standalone, but you just won't use the root yarn command
my team has a project internally to break up the apps into separate containers where appropriate, but it isn't ready to contribute back yet
(kubernetes-ey stuff)
happy to help, stick around in the channel and let everyone know what you're working on!
k
👍 thanks a bunch.
will sure do
I have a comment.
A general feedback/question: Can the install & build step not do anything with DB including migration ? Becoz the build env in very typically CI/CD place and DB migrations should happen from the app instance. A major roadblock in dockerize is this combination of db steps during build time
c
That's on my radar from the docker side as well, and we've raised it to @zomars and crew, along with the need for runtime configurability of the app urls 👍
🙏 1
k
so cool
i will workaround for now.
c
the
docker compose up -d database
command is specific for aiding the workaround for that command
so is
DOCKER_BUILDKIT=0
in the build step which uses legacy build engine which supports custom networks
k
Undestood
c
a database just needs to be available for the build at the moment, it doesn't need to be the same database used at runtime
k
agree.
Tats a nice workaround, not ideal though, but good to know you guys are working in this problem. So i will gohead proceed with my deployment in prod aws with this setup and run db-migrate