https://bentoml.com logo
Join Slack
Powered by
This message was deleted.
# ask-for-help
s
This message was deleted.
m
Umm, it seems like you’ve changed the schema… And it’s now supposed to be 
tracing.otlp.endpoint
instead of 
tracing.otlp.url
? From https://github.com/bentoml/BentoML/pull/3052/files
cc @Aaron Pham
And 
type
-> 
exporter_type
too.
s
@Aaron Pham was this change not backward compatible?
@Mike Kuhlen from the schema it looks like 
url
has been renamed to 
endpoint
. We should have maintained backward compatibility. To unblock you immediately with 
v1.0.12
, could you please try to update 
url
to 
endpoint
. We will work internally to bring back the compatibility. Sorry about interruption.
m
Thanks @Sean I should have updated. That’s exactly what we did, and also changed 
type
to 
exporter_type
. After that we got it working again. 😄
Nothing wrong in principle with backward-compatibility-breaking changes. But then it should probably have been a 
v1.1.0
, rather than just a point release.
s
Thanks for the fix forward on your end. We shouldn’t have introduced breaking changes unannounced and not reflect in the semantic versioning. It’s a bug on our side. 🙂
a
Hi @Mike Kuhlen, I believe the backward compatible layer should handle this. I will take a look into this.
can you send me your config?
m
Note sure if this what you’re looking for, but this is our BentoDeployment yaml.
Copy code
apiVersion: <http://serving.yatai.ai/v1alpha2|serving.yatai.ai/v1alpha2>
kind: BentoDeployment
metadata:
  name: hotsprings
  namespace: yatai
spec:
  autoscaling:
    max_replicas: 10
    min_replicas: 2
  bento_tag: hotsprings:27htiftxeck6uasc
  ingress:
    enabled: true
  resources:
    limits:
      cpu: 1000m
      memory: 1024Mi
    requests:
      cpu: 500m
      memory: 500Mi
  envs:
    - key: BENTOML_CONFIG_OPTIONS
      value: >-
        tracing.exporter_type=otlp
        tracing.sample_rate=1.0
        tracing.otlp.protocol=grpc
        tracing.otlp.endpoint=<http://otel-collector.big-brother.svc.cluster.local:4317>
    - key: OTEL_RESOURCE_ATTRIBUTES
      value: deployment.environment=staging
    - key: OTEL_SERVICE_NAME
      value: hotsprings
a
oh i see. I must have forgot to handle the value from the environment variable. I will fix this accordingly
Open in Slack
PreviousNext
Powered by