This message was deleted.
# ask-for-helps
Slackbot
10/13/2022, 10:47 AMThis message was deleted.
a
Adam Alpire
10/13/2022, 11:01 AMohh it seems this question is related: https://bentoml.slack.com/archives/CKRANBHPH/p1665585061732389
j
jjmachan
10/13/2022, 12:46 PMI don't think this workflow is supported straight out of the box but yatai does allow you to define your own docker registry https://docs.bentoml.org/projects/yatai/en/latest/installation/yatai_deployment.html#prepare-docker-registry that you can hook up. This means yatai and your CICD will be using the same registy and if you tag it correctly yatai should be able to pick the image up. @Xipeng Guan would that be possible?
On the other hand I was wondering why you prefer to have a the containerize step in the CI/CD instead of in yatai. Once you push the bento to yatai, it will watch for new bentos and do the containerize for you and push it to the external docker registry you use right?
a
Adam Alpire
10/13/2022, 3:45 PMIf that is actually possible, that would be awesome. Two main reasons for doing this on our own:
1. We need to pass additional parameters to the docker build, which Yatai does not support yet.
2. We anyway containerize the bento in our CICD to run ML tests.
j
jjmachan
10/14/2022, 10:59 AMwe don't support this and the workaround is probably not a good idea but
for 1. we are adding support for build args with this PR https://github.com/bentoml/yatai-deployment/pull/44 and build secrets too down the way
and for 2. that is something we are planning to do with bentoml test (but still in the design phase)
jjmachan
10/14/2022, 10:59 AMcan u check if #44 solves problem 1
a
Adam Alpire
10/14/2022, 2:38 PMI’ll have a look, thanks!
Adam Alpire
10/20/2022, 3:22 PM@jjmachan This should definitely serve our purpose, thanks. How can I test it?
Adam Alpire
10/20/2022, 3:24 PMThe only thing I am a bit unsure is this line: https://github.com/yetone/yatai-deployment/blob/5304dbd331871531449d54cda90a1d117f18222e/services/image_builder.go#L404
Copy code
args = append(args, fmt.Sprintf("--build-arg=\"%s\"", buildArg)) Copy code
bentoml containerize model:latest --build-arg GITHUB_TOKEN=$GITHUB_TOKEN10 Views