Pierre Lecerf
01/28/2025, 9:58 AMBENTOML_CONFIG_OPTIONS environment variable. Is it intended?Pierre Lecerf
01/28/2025, 9:59 AM1.1 release.Jian Shen Yap
02/03/2025, 3:16 PMPierre Lecerf
02/03/2025, 3:25 PM$BENTOML_CONFIG_OPTIONS was for dynamically tweaking some settings (could be latency settings, or parallelism) without requiring each application to systematically re-specify every option in the decorator, along with default values.
Is the environment variable still a part of the API? Or should we expect it to be deprecated in the future?Jian Shen Yap
02/03/2025, 3:50 PMsystematically re-specify every option in the decoratorwith the code being in the decorator, you can use your own environment variable which provides you more control. Does that make sense to you?
Pierre Lecerf
02/03/2025, 3:51 PMPierre Lecerf
02/03/2025, 3:58 PM$BENTOML_CONFIG_OPTIONSJian Shen Yap
02/04/2025, 11:04 AM@service({"workers" : os.environ.get("BENTOML_WORKERS")})
is not good enough?Pierre Lecerf
02/04/2025, 11:12 AMBENTOML_CONFIG_OPTIONS allows us to do.
Ideally the BentoML service definition should specify anything that's required for its operation, including relevant bentoml options, and do all that in a cohesive manner between all applications ; but in practice it's very helpful to be able to override these settings without rebuilding everything.Pierre Lecerf
02/04/2025, 5:05 PMwithout rebuilding everything..without requiring a code update followed by a rebuild, more precisely. It's the same idea behind configuration override mechanisms you can find in application frameworks such as spring, micronaut, etc. You're not supposed to handle all of your configuration settings that way, but in a pinch it makes it possible to tweak critical settings that may have been overlooked initially, and then endorse those tweaks properly later on.