Hi there,
It seems that <DeploymentStatus> should ...
# ask-for-helpj
Jean-Baptiste Lemoine
05/02/2024, 8:19 AMHi there,
It seems that DeploymentStatus should also have a scaled-to-zero value? Otherwise wait_until_ready might wait for the timeout even if the deployment succeeded.
👏 1
Jean-Baptiste Lemoine
05/02/2024, 9:06 AMSame issue here, it will fail if the status is not equal to running.
j
Jian Shen Yap
05/02/2024, 10:18 AMThanks for spotting this!
👍 1
Jian Shen Yap
05/03/2024, 10:14 AMCC: @Fog Dong
f
Fog Dong
05/06/2024, 3:58 AMThanks for pointing out! Fixed in https://github.com/bentoml/BentoML/pull/4708
👍 1
j
Jean-Baptiste Lemoine
05/06/2024, 1:30 PMI've just added a small comment https://github.com/bentoml/BentoML/pull/4708#issuecomment-2096026774
👍 1
f
Fog Dong
05/06/2024, 2:44 PMAh, sorry that I missed the client part. Fixed in https://github.com/bentoml/BentoML/pull/4712