This message was deleted.
# ask-for-help
s
This message was deleted.
c
Hi @Eric Riddoch, were you able to build a docker container image with
bentoml containerize
for this bento you are deploying?
e
Wrong Eric? ๐Ÿ˜†
๐Ÿ˜† 2
c
Ah sorry about that ๐Ÿ˜†๐Ÿ˜†
@Eric Meier were you able to solve the problem?
e
Killed my venv, started from scratch and now containerize seems to work
๐Ÿ‘ 1
The gce deployment script seems borked, aws-sagemaker seems to work though
And the aws one has a outdated aws-terraform version which prevents it from deploying a10g and a100s (easy fix). It also doesn't properly set env vars which is a bit annoying
Ended up modifying it to
Copy code
resource "aws_sagemaker_model" "sagemaker_model" {
  lifecycle {
    create_before_destroy = true
  }
  name               = "${var.deployment_name}-model-${var.image_version}"
  execution_role_arn = resource.aws_iam_role.iam_role_sagemaker.arn
  primary_container {
    image       = "${data.aws_ecr_repository.service.repository_url}@${data.aws_ecr_image.service_image.id}"
    mode        = "SingleModel"
    environment = jsondecode(replace(var.env, "'", "\""))
  }
}
Happy to do a pr if needed, (without the replace hack ofc). Is bentoctl still maintained? It seems to be riddled with small stuff like this
a
feel free to submit a PR
but I think the purpose of aws-sagemaker-deploy is that if you need modification you can fork your own and change it to your cases
but if it a general bug fix then we are happy to review it