https://bentoml.com logo
Join Slack
Powered by
# vscode-hackathon
  • e
    PR: added a trivial test and got the "Test Explorer" sidebar to work. (was really hard!)
  • e
    Our CI/CD process is working smoothly! Our test coverage is slowly rising! And tests are passing! And bumping of the semantic version in the 
    package.json
    is now enforced with each PR--so that we auto-publish the new version to the VS Code Extension Marketplace!
  • j
    Reminder: pair programming session happening in less than an hour! @doğan keskin @Oğuz Vuruşkaner
    👍 2
  • j
    Here's the link to the pair programming session @Oğuz Vuruşkaner: https://benlabs.zoom.us/j/8057133747?pwd=dXZyQklod0xkeEpzTDJGNUxlTUcrQT09
    o
    • 2
    • 2
  • j
    @Oğuz Vuruşkaner, @Mert Bozkır and I just had a productive meeting where we • discussed upcoming features • troubleshooted the 
    bentoml serve
    tests • started looking into an alternative testing framework Here are the new features we're proposing. @Eric Riddoch @noor assi @Jacob Petterle @doğan keskin, we'd love for you to reply in each new feature's thread below to tell us what you think of them.
  • j
    Feature #1: When a user clicks the Bento serving play button, the swagger docs gets opened automatically in a web browser, similar to how Jupyter Notebooks get opened.
    e
    • 2
    • 1
  • j
    Feature #2: Add a view button to the Bento serving section of the sidebar. Users should be able to view local Bentofile after clicking that button (same button as the one in the Bento section of the sidebar).
    ✅ 1
    ➕ 2
    e
    • 2
    • 1
  • j
    Feature #3: Display custom & helpful error message when Bento serving fails.
    ✅ 1
    ➕ 1
    e
    • 2
    • 2
  • j
    Feature #4: Adopt Jest as the testing framework instead of using the Electron testing framework.
    e
    o
    • 3
    • 6
  • e
    PR: added many more descriptions for 
    bentofile.yaml
    autocompletion. I made it so longer descriptions can be written as individual markdown files.
    🔥 2
    👍 2
  • m
    Guys, I’m backk! The hackathon was pretty good! 💪
    😎 1
    🎉 1
    🏁 2
  • o
    I'll be there in five minutes. @Jay Cui
    👍 1
    • 1
    • 1
  • o
    I’m currently working over these chores. • Using eslint unicorn predefined rules. • Integrating repo with SonarCloud. • Use husky for pre-commit hooks, like linting, testing, building and mandating committing rules to eliminate crappy commits. • Use path alias to get rid of relative imports.
    👍 1
    🤩 1
    e
    • 2
    • 11
  • n
    I apologize for lack of communication, I have had some job interviews that I had to focus on but I should be working on the project on Wednesday. I will keep you posted with my progress.
    ⚡ 1
    🚀 1
    e
    d
    • 3
    • 2
  • j
    Hi @doğan keskin @Eric Riddoch @Jacob Petterle @Mert Bozkır @noor assi @Oğuz Vuruşkaner, has any of you already implemented this feature? I'm going to create a feature branch to implement it right now, and I'd like to make sure there's no duplicate work.
    💙 1
    o
    e
    • 3
    • 11
  • n
    Just want to give a little update. I separated the code I have written previously into functions and I started writing the unit tests for the grouping functionality. After that I will work on fixing the delete button.
    e
    o
    j
    • 4
    • 6
  • j
    @Eric Riddoch @Oğuz Vuruşkaner Here's the PR for opening the 
    bentoml
    folder in your existing VS Code workspace. See attached video for a demo.
    opening_bentoml_dir.mov
    👀 1
    ✅ 1
  • o
    Hello there, @Jay Cui and my PRs couldn’t pass semantic versioning check. Maybe, we should separate release pipeline (CD) from CI
    j
    e
    • 3
    • 11
  • o
  • o
    ^This is an example for the suggested approach.
  • j
    There's a task in Notion called Enable 
    bentoml containerize
    in the sidebar.     For the person who requested this: do you still want this feature implemented?
    e
    • 2
    • 3
  • o
    Hey guys, I merged this PR.
    e
    • 2
    • 6
  • o
    Here is a quick overview of how to commit with conventional commits. 1. After adding changes, use 
    git commit
    2. Wait for precommit tasks ( linting and testing etc. ) 3. Construct commit message by filling commitizen instructions. 4. When vim opens, just type 
    :
    + 
    w
    + 
    q
    in this order. Your commit will be conventionalized after this step. 5. Commit is ready and can be pushed 🏁 Reference 1- Conventional Commits
    out.mp4
    🎉 2
  • o
  • n
    Hi, I am working on test cases using Mocha but I have never used it before. Would anyone be willing to help me figure it out ? I am also happy to pair program sometime this week
    e
    j
    • 3
    • 8
  • e
    I sense the group has gotten busy. I've definitely gotten busy. I'm thinking of taking 1-2 dedicated days next week to wrap up stuff and knock these out: https://bentoml.slack.com/archives/C06NB1NLG4E/p1712682829564439?thread_ts=1711081142.911809&cid=C06NB1NLG4E Then I think we'll be in a good state to hand this off to BentoML and present to them.
    n
    • 2
    • 1
  • m
    Yeah, I haven’t been able to message in here. I was participate in 2 hackathons recently 🙂 and my midterms next week (9 classes, so hard for me)
  • m
    Maybe this week I can spend 1 day for the project, then I’m gonna be available in next month, so lateee 😕
    👍 1
  • o
    Hello there, I was at holiday.
  • o
    Now, I’m back!