Hey, friends: I have a resource with this asso... Avo #avo-2

Hey, friends: I have a resource with this asso...

melodic-telephone-37659

10/26/2023, 5:23 PM

Hey, friends: I have a resource with this association:

field :service_contracts, as: :has_many, link_to_resource: true

I am seeing this error:

ActionController::UnpermittedParameters - found unpermitted parameter: :turbo_frame:

This appears to be an internal Avo thing - searched the docs - any ideas?

miniature-optician-85831

10/26/2023, 5:23 PM

Thread automatically created by hmasing in #740893011994738751

lemon-wall-20836

10/26/2023, 5:23 PM

where do you see that? on which page?

melodic-telephone-37659

10/26/2023, 5:23 PM

Show page

lemon-wall-20836

10/26/2023, 5:23 PM

otherwise, AFAIK that shouldn't impact the way Avo works

lemon-wall-20836

10/26/2023, 5:24 PM

show page of the parent resource?

melodic-telephone-37659

10/26/2023, 5:24 PM

https://cdn.discordapp.com/attachments/1167151438741389423/1167151824680276028/image.png?ex=654d15d7&is=653aa0d7&hm=026ec6e92baf212e877e590e8c6c0a6036fb8a4a01ed9547f54dc4f149613258&

melodic-telephone-37659

10/26/2023, 5:24 PM

YEs

lemon-wall-20836

10/26/2023, 5:24 PM

oh, so the problem is that you're getting Content missing

melodic-telephone-37659

10/26/2023, 5:25 PM

And the backend error is the unpermitted params above

lemon-wall-20836

10/26/2023, 5:25 PM

do you have a resource for

service_contracts

lemon-wall-20836

10/26/2023, 5:25 PM

also, what Avo version are you using?

melodic-telephone-37659

10/26/2023, 5:26 PM

class Avo::ServiceContractsController < Avo::ResourcesController end Empty controller

melodic-telephone-37659

10/26/2023, 5:26 PM

v2.34.5

lemon-wall-20836

10/26/2023, 5:26 PM

that's fine

lemon-wall-20836

10/26/2023, 5:27 PM

so that's happening when you just load the show page, right?

melodic-telephone-37659

10/26/2023, 5:28 PM

Yes

lemon-wall-20836

10/26/2023, 5:28 PM

that's weird that it's happening

lemon-wall-20836

10/26/2023, 5:29 PM

never saw it like that

loud-jewelry-99127

10/26/2023, 5:29 PM

Just to be sure, there is a resource for this controller?

lemon-wall-20836

10/26/2023, 5:29 PM

class ServiceContractsResource

melodic-telephone-37659

10/26/2023, 5:29 PM

https://cdn.discordapp.com/attachments/1167151438741389423/1167153117482209352/image.png?ex=654d170b&is=653aa20b&hm=bfa019b5e9b16eaac7f92e3fbfbd1afa72fb3bbdcaa90060a227ca5cef8c82e0&

lemon-wall-20836

10/26/2023, 5:30 PM

could you add

use_resource: ServiceContractsResource

to that field?

lemon-wall-20836

10/26/2023, 5:31 PM

field :service_contracts, as: :has_many, link_to_resource: true, use_resource: ServiceContractsResource

melodic-telephone-37659

10/26/2023, 5:31 PM

FWIW, this happens on every resource with associations.

lemon-wall-20836

10/26/2023, 5:31 PM

hmm

lemon-wall-20836

10/26/2023, 5:31 PM

now that's weird

melodic-telephone-37659

10/26/2023, 5:31 PM

🙂 I agree!

loud-jewelry-99127

10/26/2023, 5:31 PM

Singular

ServiceContractResource

lemon-wall-20836

10/26/2023, 5:31 PM

is this a greenfield app?

melodic-telephone-37659

10/26/2023, 5:31 PM

melodic-telephone-37659

10/26/2023, 5:32 PM

Adding on top of existing stack

lemon-wall-20836

10/26/2023, 5:32 PM

did associations ever work?

melodic-telephone-37659

10/26/2023, 5:32 PM

Yes, a few months back when we first toyed with avo as our admin panel, but now I've got a dev going full time on it

loud-jewelry-99127

10/26/2023, 5:33 PM

Is there any monkey patch that can impact this?

melodic-telephone-37659

10/26/2023, 5:34 PM

I only have a few - and all are things like "pluralize a symbol" or "get a percentage of a Numeric"

lemon-wall-20836

10/26/2023, 5:34 PM

or anything overriden in

Avo::ResourcesController

melodic-telephone-37659

10/26/2023, 5:34 PM

Nothing that touches Avo

lemon-wall-20836

10/26/2023, 5:34 PM

I mean, any custom methods

melodic-telephone-37659

10/26/2023, 5:35 PM

No, plain vanilla

lemon-wall-20836

10/26/2023, 5:35 PM

can you try to pinpoint the moment that they stopped working? maybe something changed along the way

lemon-wall-20836

10/26/2023, 5:35 PM

I mean, if they worked, it's kind of strange to stop working just like that

lemon-wall-20836

10/26/2023, 5:35 PM

I'd say that it's something that happened at some point

melodic-telephone-37659

10/26/2023, 5:35 PM

https://cdn.discordapp.com/attachments/1167151438741389423/1167154600529383554/image.png?ex=654d186d&is=653aa36d&hm=b629a470f03cbf85f2abc29715b9588a0cbb5425f92a261d091adbfcedc84b12&

melodic-telephone-37659

10/26/2023, 5:35 PM

Was able to get this to log

lemon-wall-20836

10/26/2023, 5:35 PM

hmmm

lemon-wall-20836

10/26/2023, 5:36 PM

ok. something to work with

lemon-wall-20836

10/26/2023, 5:36 PM

@loud-jewelry-99127 any ideas?

lemon-wall-20836

10/26/2023, 5:36 PM

we remove that file recently, right?

loud-jewelry-99127

10/26/2023, 5:37 PM

The Avo version that @melodic-telephone-37659 is using should have it

lemon-wall-20836

10/26/2023, 5:37 PM

did you override any of our View components? anything in the

/app/components/avo

directory?

melodic-telephone-37659

10/26/2023, 5:38 PM

No, don't even have that directory

melodic-telephone-37659

10/26/2023, 5:39 PM

We do use view components in our app, but they are namespaced into /app/frontend/components

lemon-wall-20836

10/26/2023, 5:39 PM

so nothing inn

/app/frontend/components/avo

either, right?

melodic-telephone-37659

10/26/2023, 5:39 PM

Negative

lemon-wall-20836

10/26/2023, 5:39 PM

hmmm

lemon-wall-20836

10/26/2023, 5:41 PM

try

gem cleanup avo

and then

bundle install

again. maybe there's a dirty state somehow?

lemon-wall-20836

10/26/2023, 5:41 PM

¯\_(ツ)_/¯

melodic-telephone-37659

10/26/2023, 5:41 PM

KK, trying now!

lemon-wall-20836

10/26/2023, 5:41 PM

also, can you search for a

_flash

partial?

melodic-telephone-37659

10/26/2023, 5:42 PM

Just our own _flash partial

melodic-telephone-37659

10/26/2023, 5:42 PM

Same

lemon-wall-20836

10/26/2023, 5:42 PM

was that there before Avo stopped working?

loud-jewelry-99127

10/26/2023, 5:44 PM

Also check if there is some code that renders a

_flash

partial that can be causing this

melodic-telephone-37659

10/26/2023, 5:45 PM

Refactoring out our internal _flash partial, one moment

melodic-telephone-37659

10/26/2023, 5:45 PM

Ahah... web | ActionView::MissingTemplate - Missing partial avo/associations/_flash_snackbar, avo/base/_flash_snackbar, avo/application/_flash_snackbar with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :jbuilder, :haml]}.

melodic-telephone-37659

10/26/2023, 5:46 PM

Renamed our flash 'flash_snackbar' and now this

loud-jewelry-99127

10/26/2023, 5:46 PM

my guess is that you have a piece of code trying to render it

loud-jewelry-99127

10/26/2023, 5:47 PM

and is getting the wrong path

melodic-telephone-37659

10/26/2023, 5:47 PM

So it looks like it's coming from our code. Yeah, this is super helpful. Digging in. I'll keep you posted

melodic-telephone-37659

10/26/2023, 5:47 PM

Found it

melodic-telephone-37659

10/26/2023, 5:47 PM

https://cdn.discordapp.com/attachments/1167151438741389423/1167157685205078146/image.png?ex=654d1b4c&is=653aa64c&hm=7c89b9e5da42ea10a1adc8bf4cf8bb7d4020f6045b11e86fcfe657041f9dc534&

melodic-telephone-37659

10/26/2023, 5:48 PM

And now things work. Tada!

lemon-wall-20836

10/26/2023, 5:48 PM

that layout is being used when the Avo code loads a turbo frame and that isn't available so it crashes

lemon-wall-20836

10/26/2023, 5:48 PM

interesting bug

lemon-wall-20836

10/26/2023, 5:49 PM

I was thinking of overriding that layout file, but now I'm cured of that pattern 😛

lemon-wall-20836

10/26/2023, 5:49 PM

... to do the same thing BTW 😛

lemon-wall-20836

10/26/2023, 5:49 PM

display flashes

melodic-telephone-37659

10/26/2023, 5:50 PM

We do use that for flash messages in the client-facing part of the app, so I'll need to figure out how to make that work

lemon-wall-20836

10/26/2023, 5:50 PM

please let us know what you settle on. it's something that we'd like to refactor in our apps too

melodic-telephone-37659

10/26/2023, 5:53 PM

And likewise, if you find a solution and remember this conversation, I'm all ears!

lemon-wall-20836

10/26/2023, 5:56 PM

sure

lemon-wall-20836

10/26/2023, 5:56 PM

right now I use a partial that I include in each response

.turbo_stream.erb

file

lemon-wall-20836

10/26/2023, 5:56 PM

definitely not the right thing to do

lemon-wall-20836

10/26/2023, 5:57 PM

I think this can be fixe dif you use an absolute path

lemon-wall-20836

10/26/2023, 5:57 PM

render 'something/deep/in/your/app/flash

lemon-wall-20836

10/26/2023, 5:57 PM

this way when Avo tries to load it it will have the full path and won't choke

lemon-wall-20836

10/26/2023, 5:58 PM

but, that will also mean you'd render the erros twice

lemon-wall-20836

10/26/2023, 5:58 PM

hmmm

lemon-wall-20836

10/26/2023, 5:58 PM

you need a conditional there.

Copy code

ruby
unless Avo
  render flash
end

lemon-wall-20836

10/26/2023, 5:59 PM

unless controller.controller_name.starts_with? "Avo::

maybe

melodic-telephone-37659

10/26/2023, 6:00 PM

I'll try an absolute path, one sec

melodic-telephone-37659

10/26/2023, 6:01 PM

Abolute path fixes the issue

lemon-wall-20836

10/26/2023, 6:02 PM

yes, but when you have an error in Avo, does that render the flash messages twice?

melodic-telephone-37659

10/26/2023, 6:02 PM

https://cdn.discordapp.com/attachments/1167151438741389423/1167161229249355836/image.png?ex=654d1e99&is=653aa999&hm=f06c422224633dd2da3d41b5066f357bc312fce79fba6b463655c9f3ff27b030&

melodic-telephone-37659

10/26/2023, 6:02 PM

Checking for double render, one moment

melodic-telephone-37659

10/26/2023, 6:02 PM

No double render

lemon-wall-20836

10/26/2023, 6:02 PM

cool! you should be good to go then 🙂

melodic-telephone-37659

10/26/2023, 6:02 PM

Thanks, guys!

lemon-wall-20836

10/26/2023, 6:03 PM

anytime!

melodic-telephone-37659

10/26/2023, 6:03 PM

Glad this was, at least, a unique problem 🙂

melodic-telephone-37659

10/26/2023, 8:27 PM

Hey, gents! One more, if I may: https://cdn.discordapp.com/attachments/1167151438741389423/1167197952524161085/image.png?ex=654d40cd&is=653acbcd&hm=e87f28cc6318996411fb4098c99f2e2c7ed2e1d083bfde166499090d0d06c7fb&

melodic-telephone-37659

10/26/2023, 8:29 PM

Any idea why the service contracts and marketing agreements render differently?

melodic-telephone-37659

10/26/2023, 8:30 PM

https://cdn.discordapp.com/attachments/1167151438741389423/1167198672660996096/image.png?ex=654d4179&is=653acc79&hm=57585e3624b9f70a924617ce5602d3b48c1dc1465c331692e12d7e4a107f37e9&

melodic-telephone-37659

10/26/2023, 8:31 PM

Service Contracts show the Service Provider name, Marketing Agreements do not

melodic-telephone-37659

10/26/2023, 8:32 PM

the Service Contract Resource has:

Copy code

field :service_contracts, as: :has_many, link_to_resource: true
  field :marketing_agreements, as: :has_many, link_to_resource: true

loud-jewelry-99127

10/26/2023, 8:34 PM

The show page of that marketing agreement shows the service provider correctly?

melodic-telephone-37659

10/26/2023, 10:32 PM

Yes

loud-jewelry-99127

10/27/2023, 5:40 AM

The model associations coincide whit the resource associations?

loud-jewelry-99127

10/27/2023, 5:46 AM

Since you're on service provider show page, all related association table should omit the service provider column. Marketing agreements is looking great, would need to have a reproduction repoitory in order to debug this one

lemon-wall-20836

10/27/2023, 7:03 AM

can you share the service provider resource config too?

melodic-telephone-37659

10/27/2023, 9:37 AM

https://cdn.discordapp.com/attachments/1167151438741389423/1167396615028490240/image.png?ex=654df9d2&is=653b84d2&hm=5278c2a133bb8b69809d7133ce9f7f18f4d24fcf6a9a41578e21f6ded3787c35&

loud-jewelry-99127

10/27/2023, 9:39 AM

Can you share the model association relevant configuration betwen

Service::Provider

Marketing::Agreement

Service::Provider

Service::Contract

melodic-telephone-37659

10/27/2023, 10:34 AM

Was a missing inverse_of on the Service::Contract. Thanks!

melodic-telephone-37659

10/27/2023, 10:35 AM

I appreciate the support, again! you guys are great.

melodic-telephone-37659

10/27/2023, 10:35 AM

I'll try to keep the questions down 😉

lemon-wall-20836

10/27/2023, 10:38 AM

sometimes, when you have more code to show, a github issue might work better

melodic-telephone-37659

10/27/2023, 10:38 AM

Will do!

lemon-wall-20836

10/27/2023, 10:38 AM

thanks! https://avo.cool/new-issue

melodic-telephone-37659

11/15/2023, 1:54 PM

@loud-jewelry-99127 The attachment issue you were helping me with may be our old turbo_rails issue above....

melodic-telephone-37659

11/15/2023, 1:54 PM

LMK if a git issue would be easier

lemon-wall-20836

11/15/2023, 1:55 PM

yes, please 🙏

melodic-telephone-37659

11/15/2023, 2:03 PM

https://github.com/avo-hq/avo/issues/2032

Previous Next