Do the descope-swift and descope-kotlin GitHub projects accept external PRs?

You're welcome to contribute to either!

Great! Thanks. We need support for custom cookie names just like the React SDK. Is this feature incoming or would that be a welcome contribution?

@Kevin Gao Any idea if this is something we're actively working on?

Hey @Benjamin Cassidy, are you using native flows with the Kotlin SDK? With mobile the session management works a little bit differently than the web. With the Kotlin SDK, the cookies are set in the browser, based on the configuration within your Descope project. You don't necessarily have to configure anything in the Kotlin SDK itself, and if you're using the

sessionManager

you'll have access to the session/access token from that.

@Kevin Gao We have a flow for user log in the uses custom cookie names. This breaks the mobile SDKs. The cookie names are hardcoded in the swift sdk:

static let sessionCookieName = "DS"
    static let refreshCookieName = "DSR"

just as they are in the kotlin sdk:

internal const val SESSION_COOKIE_NAME = "DS"
internal const val REFRESH_COOKIE_NAME = "DSR"

This means that when we use custom cookie names, the mobile SDKs cannot find them when it reads the cookies from the web view. The flow creates the cookies as "custom_session_cookie" and "custom_refresh_cookie" instead of the default "DS" and "DSR".

Oh I see what you're saying, the session manager can't get set because of this

Yeah

Oh I was just going to say I already opened a PR for this

I didn't see those in the public repos.

Gotcha. Thank so much, @Kevin Gao

I haven't looked at the SDK yet, if it's the same boat then I'll add quickly. Have a meeting in like 3 mins but I'll look after if that's ok.

Thank you!

Excellent! Looks good. Thank you. Will you cut new releases after these are merged?

Yep it should automatically release once I create it in GitHub

Hey, @Kevin Gao. Do you have an update on when these PRs will be merged? We have an internal deadline that's being held up until we can get the mobile apps working with the custom cookie names. Thank you

Hi Benjamin, Quick update here. After discussing with the team, the big issue is that if we release this, then the cookie name will be permanently set within the app as a static variable, and if that ever changes, that would require a person have to update the application in order to make the new name work. We would rather implement this in such a way where our backend will return the cookie name instead, making it more dynamic in nature. I’m currently working on getting an ETA for this but we’re trying to expedite this as fast as possible for you guys

Thanks for the update. It's implemented with manual overrides in the Javascript SDKs which we're also using. Will those be changed as well to fetch the custom cookie name from the Descope API based on the project configuration?

I believe that's the plan. It looks like we're going to deploy the backend change to production on Wednesday evening, so we will release a new SDK version that's compatible with this shortly thereafter

Hi @Kevin Gao and @Gil Shapira The MRs for both platforms got merged. But I'm not seeing new releases for the swift and kotlin SDKs. Do you have an estimate on when those will be created?

Yea, we will. I'll ping here once the new versions are tested and released.

Thank you