Even tho we dont want atlantis to be a version man...
# atlantis-contributors
r
Even tho we dont want atlantis to be a version manager in the future... since it is and regarding the recent fix for 1.8.2, what do you folks, think of adding (or keeping) a configurable max anyway for issues like https://github.com/runatlantis/atlantis/issues/3199#issuecomment-1513187272?
If the above proposal is accepted, this would impact current prs trying to solve for versions 1.8.2 and higher since those also remove the 1.8.2 restriction
c
I could see that being useful in a couple of use-cases we have at SeatGeek 🙂 enforcing semver constraint Atlantis must stay within
could also be enforced with conftest tbh, but a lot of wiring to get that up and running if you don't use it for anything else
r
It wouldnt really be enforced by conftest. The required_version would be gated by conftest which would then force the user to update every root dir which is the same case today. This is why a lot of users want a max constraint. Since we have one already, it would be nice to maintain it but make it configurable. It would come in handy in my env too where the required_version is set at times and many times is unset.
@James Brookes @PePe Amengual
j
Any approach adding a Min/Max constraint should integrate quite nicely into
hc-install
usage - you could adjust this line
Copy code
constraintStr := requiredVersionSetting
	vc, err := version.NewConstraint(constraintStr)
into a constraint string. e.g.
Copy code
constraintStr := requiredVersionSetting
if <max value arg> is not ""	
	constraintStr := fmt.Sprintf("%s, %s", requiredVersionSetting, <pass in max arg>)
vc, err := version.NewConstraint(constraintStr)
👍 1
👍🏽 1