This message was deleted.
# atlantis-contributors
s
This message was deleted.
l
I want to make sure we have consistency in our errors, but also make them easy to read wherever they show up
I think the solution here would be to keep error strings themselves of the form
doing a thing
and have whatever writes to the comment itself prepend
Error: <>
Also I have been thinking about this, https://github.com/pkg/errors has been abandoned in favor of improved error wrapping in the stdlib, we should probably transition to that as well 🤔
p
I'm not opposed to better error handling or debugging , especially from prep and post workflows
l
I think my approach would be 1. Remove references to pkg/errors, replace with stdlib errors 2. Enforce (or at least do a pass at cleaning up) the "no `Error: ...`" rule, at the same time making sure the thing that actually prints the error makes it clear it's an error
d
The contribution guide is correct
l
I agree
but the issue is it yields an awkward comment, which is what https://github.com/runatlantis/atlantis/pull/4177 is trying to address
(at least partially)
I think the right solution is for the actual errors to conform to this rule, but then when we write the errors somewhere we say
fmt.Printf("Error: %v", err)
So I think for this PR the options are: 1. Have the user remove
Error:
from the error string and leave the VCS comment as is 2. Leave the
Error:
in the comment and attempt to address the formatting of the comment in a different issue 3. Have the user address the formatting of the comment in this issue
p
maybe is better to leave the VCS output as is?
l
So option 1?
p
yes
l
ok I unresolved the comment
👍🏽 1