https://www.runatlantis.io/ logo
Join Slack
Powered by
This message was deleted.
# atlantis-contributors
s
This message was deleted.
l
Copy code
--- FAIL: TestRenderProjectResults (0.01s)
    --- FAIL: TestRenderProjectResults/single_successful_plan (0.00s)
        --- FAIL: TestRenderProjectResults/single_successful_plan/single_successful_plan (0.00s)
I noticed it in what I believe is an unrelated PR https://github.com/runatlantis/atlantis/actions/runs/7234266257/job/19710468454?pr=4064, and am also seeing it locally
I ran 
make test
on that commit locally and it failed w the same errors, then I went backwards one commit and did not get the errors
@David Glasser ^^
I have to run for the evening, but can dig in further tomorrow if need be
Ah yeah, here's the diff
Copy code
exp: Ran Plan for 3 projects:
                
                1. dir: `path` workspace: `workspace`
                1. project: `projectname` dir: `path2` workspace: `workspace`
                1. project: `projectname2` dir: `path3` workspace: `workspace`
                
                * :fast_forward: To **apply** all unapplied plans from this pull request, comment:
                    * `atlantis apply`
                * :put_litter_in_its_place: To delete all plans and locks for the PR, comment:
                    * `atlantis unlock`******
                got: Ran Plan for 3 projects:
                
                1. dir: `path` workspace: `workspace`
                1. project: `projectname` dir: `path2` workspace: `workspace`
                1. project: `projectname2` dir: `path3` workspace: `workspace`
                
                * :fast_forward: To **apply** all unapplied plans from this pull request, comment:
                    * `atlantis apply`
                * :put_litter_in_its_place: To **delete** all plans and locks for the PR, comment:
                    * `atlantis unlock`
note the 
delete
vs 
**delete**
OK I was able to put together a PR to fix this: https://github.com/runatlantis/atlantis/pull/4066
✅ 1
merged1 1
@PePe Amengual / @Dylan Page if you could take a look
p
✅
d
Whoops, I'm sorry. Why wasn't this caught by CI on my PR itself? https://github.com/runatlantis/atlantis/pull/4044 I'm admittedly new to Atlantis dev and I might not have locally run all the tests correctly, but I figured that PR CI would catch things...
Or ah, was the issue only in the release branch cherry-pick #4049?
Ah no it was in my PR. But the "should run tests" check is not sensitive enough. https://github.com/runatlantis/atlantis/actions/runs/7188466654/job/19602977661
Copy code
changes:
    outputs:
      should-run-tests: ${{ steps.changes.outputs.go == 'true' }}
    if: github.event.pull_request.draft == false
    runs-on: ubuntu-22.04
    steps:
      - uses: actions/checkout@v4
      - uses: dorny/paths-filter@v2
        id: changes
        with:
          filters: |
            go:
              - '**.go'
              - 'go.*'
              - '.github/workflows/test.yml'
I suggest that changes to 
testdata
should be enough to run tests?
l
Ah yeah that makes sense
Thanks for digging into that!
I rebased the original PR that made me aware of the issue https://github.com/runatlantis/atlantis/pull/4064 so I think this particular issue is all good now, thanks!
merged1 1
✅ 1
I agree w looking into expanding the situations in which that particular CI runs
2 Views
Open in Slack
PreviousNext
Powered by