This message was deleted.
# atlantis-contributors
s
This message was deleted.
l
Looking more closely
looks like a new version of curl was just released https://github.com/curl/curl/releases/tag/curl-8_5_0
I was able to reproduce locally:
Copy code
atlantis % docker run -it <http://docker.io/library/alpine:3.18.5|docker.io/library/alpine:3.18.5> /bin/sh
Unable to find image 'alpine:3.18.5' locally
3.18.5: Pulling from library/alpine
c926b61bad3b: Already exists 
Digest: sha256:34871e7290500828b39e22294660bee86d966bc0017544e848dd9a255cdf59e0
Status: Downloaded newer image for alpine:3.18.5
/ # apk add --no-cache         ca-certificates~=20230506         curl~=8.4         git~=2.40         unzip~=6.0         bash~=5.2         openssh~=9.3_p2         dumb-init~=1.2       
  gcompat~=1.1
fetch <https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz>
fetch <https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz>
ERROR: unable to select packages:
  curl-8.5.0-r0:
    breaks: world[curl~8.4]
More specifically:
Copy code
atlantis % docker run -it <http://docker.io/library/alpine:3.18.5|docker.io/library/alpine:3.18.5> apk add --no-cache curl~=8.4
fetch <https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz>
fetch <https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz>
ERROR: unable to select packages:
  curl-8.5.0-r0:
    breaks: world[curl~8.4]
I don't know how apk package management works, but it seems like it's saying, now that 8.5.0-r0 (which I'm reading as "release candidate 0") is available, it's impossible to install 8.4
I guess they just don't keep the old ones at all?
I put up a PR to relax the condition to just 8: https://github.com/runatlantis/atlantis/pull/4019
Ah, it looks like that's not what's typically done here; all the other utilities here have minor and major versions, I'll keep it that way
Longer term, maybe we unpin alpine like we did for debian? https://github.com/runatlantis/atlantis/pull/3528 Not sure how much pinning minor version is getting us for things like curl
or maybe switch all those utilities to major? (i.e.
~=8
instead of
~=8.5
)
@PePe Amengual ++ thanks for accepting my PR, it looks like CI is working again
I put in a follow up PR to reduce the likelihood of this issue, open to feedback: https://github.com/runatlantis/atlantis/pull/4024
p
yes this has been a pain for a while, specially with Curl
👍 1
if I remember correctly we went from no pin to strict pin
And I think mayor version pin is totally fine
we do not need to pin a minor version I think
@Dylan Page
d
You will not get any disagreements from me
p
Approved and merged
👍 2