This message was deleted Atlantis #atlantis-community

Join Slack

This message was deleted.

# atlantis-community

Slackbot

11/15/2023, 4:41 PM

This message was deleted.

PePe Amengual

11/15/2023, 4:47 PM

two Atlantis servers?

Wendell Beckwith

11/15/2023, 4:49 PM

Yes, one in each env. Security doesn't allow for 1 atlantis server to have permissions to modify everything.

PePe Amengual

11/15/2023, 4:53 PM

ok, do you have the silence-no-project and the Atlantis-exec name settings added?

Wendell Beckwith

11/15/2023, 4:57 PM

Had to check, we have

Copy code

hide-prev-plan-comments: true
#hide-unchanged-plan-comments: true
quiet-policy-checks: true

PePe Amengual

11/15/2023, 5:03 PM

same repos too?

Wendell Beckwith

11/15/2023, 5:04 PM

Yes, they both target the same repo in this case. Legacy issue.

PePe Amengual

11/15/2023, 5:04 PM

then you need to change the atlantis config because both apps respond to the same events

PePe Amengual

11/15/2023, 5:06 PM

https://www.runatlantis.io/docs/server-configuration.html#silence-vcs-status-no-plans

PePe Amengual

11/15/2023, 5:06 PM

https://www.runatlantis.io/docs/server-configuration.html#silence-no-projects

PePe Amengual

11/15/2023, 5:06 PM

https://www.runatlantis.io/docs/server-configuration.html#vcs-status-name

PePe Amengual

11/15/2023, 5:07 PM

https://www.runatlantis.io/docs/server-configuration.html#vcs-status-name

PePe Amengual

11/15/2023, 5:08 PM

all those options where added to be able to run multiple atlantis servers in one repo

Wendell Beckwith

11/15/2023, 5:08 PM

Ok, the way we currently have it is that this repo "foo", currently has an atlantis-prod.yaml and an atlantis-test.yaml. The atlnatis-prod instance uses the atlantis-prod.yaml and the atlantis instance builds for atlantis.yaml. At present, I don't think we have an issue with the plan, it's where 1 can apply and close the PR even if the other has checks still waiting.

Wendell Beckwith

11/15/2023, 5:09 PM

We did review those, and maybe we are misunderstanding how they can be applied in our situation.

PePe Amengual

11/15/2023, 5:10 PM

you need to tell the atlantis servers to only care about the projects configured on their own atlantis.yaml files

PePe Amengual

11/15/2023, 5:11 PM

and to ignore all other projects

PePe Amengual

11/15/2023, 5:12 PM

because all VCSs events will hit both servers, with valid payloads and both are going to parse the payload and pull the repo

PePe Amengual

11/15/2023, 5:12 PM

so they can both respond

PePe Amengual

11/15/2023, 5:14 PM

if you have separated them by using vcs-status-name etc you can basically instruct each atlantis server to ignore the projects and then no status is changed

👀 1

PePe Amengual

11/15/2023, 5:15 PM

it says it right there

PePe Amengual

11/15/2023, 5:15 PM

and

PePe Amengual

11/15/2023, 5:15 PM

https://www.runatlantis.io/docs/server-side-repo-config.html#multiple-atlantis-servers-handle-the-same-repository

Wendell Beckwith

11/15/2023, 5:17 PM

OK, I previously posed the setting for the test atlantis instance. From looking at the prod instance we have the following configured

Copy code

silence-vcs-status-no-plans: true
silence-no-projects: true
hide-prev-plan-comments: true
#hide-unchanged-plan-comments: true
quiet-policy-checks: true
parallel-pool-size: 50
vcs-status-name: atlantis-prod
executable-name: atlantis-prod

PePe Amengual

11/15/2023, 5:18 PM

the test instance should look the same but

-test

Wendell Beckwith

11/15/2023, 5:26 PM

So assuming that the test instance was as you describe, what's the workflow. So we have a 1. A PR is opened for a project in the test env. 2. Both Atlantis servers will be notified via webhook. 3. The prod instance will see that the project is not in it's configured atlantis-prod.yaml and do nothing. 4. The test instance will see that it does need to run a build and will post the plan results back to the PR under the name

atlantis-test

. 5. A user will then approve PR and comment

atlantis-test apply

and the PR will be applied and closed. Is the above the correct flow of events for the single project case?

PePe Amengual

11/15/2023, 5:27 PM

yes

PePe Amengual

11/15/2023, 5:27 PM

basically one server will always ignore

PePe Amengual

11/15/2023, 5:28 PM

which version of atlantis?

Wendell Beckwith

11/15/2023, 5:31 PM

OK, great. Here is where we think things are breaking down. 1. A PR is opened for a project in the test env and a project in prod. 2. Both Atlantis servers will be notified via webhook. 3. The prod instance will see that it needs to plan a project in the PR and will do so, resulting in PR comments under the

atlantis-prod

name. 4. The test instance will see that it too needs to plan a project and will post the plan results back to the PR under the name

atlantis-test

. 5. A user will then approve PR and comment

atlantis-test apply

and the PR will be applied and closed. 6. The prod project was never applied.

Wendell Beckwith

11/15/2023, 5:31 PM

Let me check on the version.

Wendell Beckwith

11/15/2023, 5:35 PM

v0.23.3

PePe Amengual

11/15/2023, 5:36 PM

you will need to configure the test atlantis to not merge the PR

PePe Amengual

11/15/2023, 5:37 PM

because at the end the

"promotion"

to prod is what actually validates the code so in a way the prod deploy should merge the PR since is the

source of truth

PePe Amengual

11/15/2023, 5:39 PM

I think maybe there is a limitation on the locks here too because the repo should be locked for the prod server when there is a PR in flight

PePe Amengual

11/15/2023, 5:40 PM

but the Lock is not shared so the prod server does not know about it

PePe Amengual

11/15/2023, 5:41 PM

and actually you could be applying an already tested code that you deploy to test but now you are promoting to prod, so the PR in test is ahead and doing something else but prod is applying behind test

PePe Amengual

11/15/2023, 5:41 PM

interesting

PePe Amengual

11/15/2023, 5:42 PM

I’m trying to think if I ever run into this problem before when I had two servers

Wendell Beckwith

11/15/2023, 5:44 PM

It's really like we need the 2 servers to ask each other if it's OK I merge this PR. Prod says I'm not doing anything we that PR, so go ahead. Or whoa, I have an open plan on that guy, hold off.

PePe Amengual

11/15/2023, 6:01 PM

and that is really hard

Open in Slack

Previous Next