This message was deleted.
# atlantis-contributorss
Slackbot
11/04/2023, 6:39 PMThis message was deleted.
p
PePe Amengual
11/04/2023, 9:28 PM@Gabriel Martinez do you have some time?
PePe Amengual
11/04/2023, 9:28 PMwe are a bit busy, but we will get to it
g
Gabriel Martinez
11/04/2023, 10:36 PMHey! Tomorrow I’m taking some time for OSS. I’ll take a look 🙂
p
PePe Amengual
11/04/2023, 11:50 PMthanks Gabriel
g
Gabriel Martinez
11/05/2023, 4:02 PMLooks good overall 🙂 thanks @רועי טבת! Left some comments.
u
רועי טבת
11/05/2023, 4:41 PMHi @Gabriel Martinez thanks for your review ive made the changes 🙂
🙌 1
רועי טבת
11/05/2023, 7:54 PMHi @Gabriel Martinez please see when you can
g
Gabriel Martinez
11/05/2023, 9:03 PMApproved 🙂
u
רועי טבת
11/05/2023, 9:03 PMThanks!!!
רועי טבת
11/06/2023, 4:11 PM@PePe Amengual hi! Can you please take a look? 😁
p
PePe Amengual
11/06/2023, 4:16 PMI will today
🙌 1
u
רועי טבת
11/09/2023, 7:02 PMHi @PePe Amengual will you please be able to look? 😁 I really want to take more tasks in this space
p
PePe Amengual
11/09/2023, 7:28 PMcan you look at errors in the test?
u
רועי טבת
11/09/2023, 7:42 PMSure I saw missing space I’ve added it
רועי טבת
11/09/2023, 7:42 PMAnd thanks @PePe Amengual
p
PePe Amengual
11/09/2023, 7:57 PMmore errors…
u
רועי טבת
11/09/2023, 8:23 PM@PePe Amengual Sorry about it in the ci/values-ci.yaml it had secondary_ingress: option which is not supported(should be webhook_ingress) i changed it it means that the schema validation does work 🙂
רועי טבת
11/09/2023, 9:11 PM@PePe Amengual It passed now thanks
p
PePe Amengual
11/09/2023, 9:16 PMmerged1
u
רועי טבת
11/09/2023, 9:17 PM@Gabriel Martinez and @PePe Amengual thanks for your time and help 😁
🙌 1