https://www.runatlantis.io/ logo
Join Slack
Powered by
This message was deleted.
# atlantis-contributors
s
This message was deleted.
p
Approved and merged
l
👍
I started digging deeper and saw this:
Copy code
atlantis % go test <http://github.com/runatlantis/atlantis/server/events|github.com/runatlantis/atlantis/server/events>
# <http://github.com/runatlantis/atlantis/server/events_test|github.com/runatlantis/atlantis/server/events_test> [<http://github.com/runatlantis/atlantis/server/events.test|github.com/runatlantis/atlantis/server/events.test>]
server/events/event_parser_test.go:49:35: cannot use &Repo (value of type *"<http://github.com/google/go-github/v54/github|github.com/google/go-github/v54/github>".Repository) as *"<http://github.com/google/go-github/v55/github|github.com/google/go-github/v55/github>".Repository value in argument to parser.ParseGithubRepo
server/events/event_parser_test.go:66:9: cannot use &Repo (value of type *"<http://github.com/google/go-github/v54/github|github.com/google/go-github/v54/github>".Repository) as *"<http://github.com/google/go-github/v55/github|github.com/google/go-github/v55/github>".Repository value in struct literal
server/events/event_parser_test.go:136:89: cannot use &PullEvent (value of type *"<http://github.com/google/go-github/v54/github|github.com/google/go-github/v54/github>".PullRequestEvent) as *"<http://github.com/google/go-github/v55/github|github.com/google/go-github/v55/github>".PullRequestEvent value in argument to parser.ParseGithubPullEvent
server/events/event_parser_test.go:307:67: cannot use &Pull (value of type *"<http://github.com/google/go-github/v54/github|github.com/google/go-github/v54/github>".PullRequest) as *"<http://github.com/google/go-github/v55/github|github.com/google/go-github/v55/github>".PullRequest value in argument to parser.ParseGithubPull
FAIL	<http://github.com/runatlantis/atlantis/server/events|github.com/runatlantis/atlantis/server/events> [build failed]
FAIL
I don't know how renovate works, whether it'll come around again and try to make the change again
p
it happens some times
if we close the PR when it creates it it does not try again
I think maybe we should put a filter to avoid updating VCSs libraries or somehow fix the test in some automated way
l
Would it be possible to prevent renovate from merging if it fails the CI?
p
it should not merge if CI failed
l
https://github.com/runatlantis/atlantis/pull/3743; it looks like it didn't even run CI?
p
no it looks like it does not run the same tests….
l
oh huh
p
I did not setup this
l
I can open an issue if you want?
p
yes please, I have no idea how renovate works
👍 1
@Dylan Page or @RB have any clue?
l
r
There's an open issue on this. We've investigated this before. Basically the negative test for the required check is running instead of the positive test and that's why it's passing. We haven't investigated why that's happening tho. Once that is fixed then renovate will be unable to merge since the test will fail Also renovate is failing to update one of the libraries. It happens every time the GitHub golang lib is updated
Oh nevermind i cannot find an open issue. We just have discussed this in a previous renovate pr but never created an issue. Thank you for creating the issue so we can track it
👍 1
Here is the last time i fixed the GitHub golang lib. I'll link it in the new ticket since it contains references to where renovate is deficient https://github.com/runatlantis/atlantis/pull/3498
d
We should just remove the negative tests, I think someone wrote a PR with doing the logic within the test
r
ya if it works better than do it. the path based negative test approach, as recommended by gha, is tricky to debug. I think this approach you’ve linked is easier to test and troubleshoot going forward 🙂
👍 1
Open in Slack
PreviousNext
Powered by