This message was deleted.
# atlantis-communitys
Slackbot
08/18/2023, 2:32 PMThis message was deleted.
g
Gabriel Martinez
08/18/2023, 2:45 PMJust tested it and I can confirm
make lintGabriel Martinez
08/18/2023, 2:46 PMlooks related to a
revivej
jsarry
08/18/2023, 2:49 PMIs revive a commit?
g
Gabriel Martinez
08/18/2023, 2:50 PMit’s a go linter -> https://github.com/mgechev/revive
Gabriel Martinez
08/18/2023, 2:50 PMexample
Copy code
server/controllers/events/events_controller_e2e_test.go:56:36: unused-parameter: parameter 'dst' seems to be unused, consider removing or renaming it as _ (revive)
func (m *NoopTFDownloader) GetFile(dst, src string) error {(revive)Gabriel Martinez
08/18/2023, 2:50 PMon this one it’s
(gosimple) Copy code
server/core/config/raw/global_cfg.go:283:77: S1002: should omit comparison to bool constant, can be simplified to `!*r.PolicyCheck` (gosimple)
if globalReq == valid.PoliciesPassedCommandReq && r.PolicyCheck != nil && *r.PolicyCheck == false {j
jsarry
08/18/2023, 2:58 PMAhh ok so the linter has changed. If I use an older version. It should.be fine.
🤞 1
g
Gabriel Martinez
08/18/2023, 2:59 PMit’s probably this PR released on <https:v1.3.0|v1.3.0>
Gabriel Martinez
08/18/2023, 3:00 PMI’ve had this before on other repos. Although I’d say we should have the rules on the repo to prevent this for other contributors
j
jsarry
08/18/2023, 3:02 PMMakes sense. Thanks for clearing this up.
😊 1
p
PePe Amengual
08/18/2023, 3:21 PMmmmm I’m looking at the atlantis PRs an I do not find any `revive`related PRs recently
PePe Amengual
08/18/2023, 3:23 PMohhh the workflow
PePe Amengual
08/18/2023, 3:23 PMI bet we are just using latest….I had so many issue with workflows lately that we should start pinging minor versions
g
Gabriel Martinez
08/18/2023, 3:24 PMI’m happy to send a PR to fix all these linter errors
Gabriel Martinez
08/18/2023, 3:25 PMbut I have to rely on the tests to not break anything
Gabriel Martinez
08/18/2023, 3:25 PMsince I’m not aware of most of the codebase
p
PePe Amengual
08/18/2023, 3:25 PMsure, please do
👍 1