This message was deleted.
# atlantis-contributors
s
This message was deleted.
r
taking a look
i think i figured it out. running tests locally and will push a fix shortly if it’s good
d
Thanks ross 👍
r
of course!
hmm that failing test didn’t show up locally, looking
d
thank you
might be surfaced in a different PR
I can help in a hour after this meeting
r
sounds good. i think i’m pretty close to the cause
ultimately, reconciliation of global vs repo-level params never happens in this test: https://github.com/runatlantis/atlantis/blob/main/server/events/command_runner_test.go#L690-L737 because there projectcontext is returned with default values, where automerge is
false
. the change in logic for reconciling automerge is disconnected in this test. i’ve manually set these values in the projectcontext: https://github.com/runatlantis/atlantis/pull/3591/files#diff-4dc8fc56c41b19dd6e51a9fda6d2542dc91a3b3137007185306660ffe6789509R704 this fixes the issue, but it might not be an ideal approach, due to clarity, if further tests are built out in this area.
👀 1
d
interesting, good catch and thank you for the comments
r
no problem, apologies this slipped through
💯 1
d
No worries, this codebase is a bit of a monster so I’m not surprised