https://www.runatlantis.io/ logo
Join Slack
Powered by
This message was deleted.
# atlantis-contributors
s
This message was deleted.
p
I have no idea why is failing now
j
the original failure, is that bats changed how they tag images.
if you fix that, this 
cp -R /usr/local/libexec/ /tools/bats/
then fails
i tried mucking with it, but i still fail 
cp /usr/local/bin/bats /tools/bats/bats
g
can you try:
Copy code
mkdir -p /tools/bats
cp /usr/local/bin/bats /tools/bats/
j
changed/pushed
🤞 1
g
or (notice the cp and command key changed)
Copy code
# copy bats to tools dir
        cp /usr/local/bin/bats /tools/
      volumeMounts:
      - mountPath: /tools
        name: tools
  containers:
    - name: {{ .Release.Name }}-ui-test
      image: {{ .Values.test.image }}:{{ .Values.test.imageTag }}
      command: ["/tools/bats", "-t", "/tests/run.sh"]
      volumeMounts:
j
my push isnt showing 😕
g
Github is having issues right now
j
ahhh hope thats it lol
😆 1
g
j
env: can't execute '/tools/libexec/bats-core/bats': No such file or directory
p
I was checking the container and it has not changed in like 4 months ( bats container)
g
Let me test that locally
j
Can we get this merged, so we can move forward on all the other open MR's Thanks.,
🙏 1
@PePe Amengual what would need to happen, to get additional people who can approve merges on the Helm Chart? We are actively getting people creating issues, and providing Pull Requests and then they seem to just get stuck waiting.
I understand you all have other things to do. So dont take that has a critical complain or anything
p
time….
let me take another look in a few
🙌 2
merged
please check
g
Thanks @PePe Amengual 🙏
If you’re looking for a hand on maintaining this helm chart I’m happy to help. I’m also a maintainer on the kube-prometheus-stack helm chart. Just trying to give back 😊
p
amazing , we will add you to the channel
👍 1
j
can we also format the yaml so my editor stops breaking all of my Merge Requests lol
g
Send a PR 🙂
j
I managed to lose all my changes merging in your changes
i shouldnt git this early in the AM<
g
Use git reflog to bring them back
j
it even closed mty MR
no idea at this point
pushed the stuff back, MR is still closed
g
I think it won’t re-open by itself, you’ll just update the branch
does it work if you manually re-open the PR?
j
I am able to create a new PR, yes
even pushing a new change, does nothing
I dont get how telling github to sync my fork would make it this unusable.
g
looks like your branch is still behind main
j
Im not sure why that would be an issue?
Copy code
This branch has conflicts that must be resolved

Discard 5 commits to make this branch match the upstream repository. 5 commits will be removed from this branch.

You can resolve merge conflicts using the command line and a text editor.
Im not sure why I would need to catch up to main, to do a Pull Request, i certainly dont need to do that at work. But Im unable to do that, since last time, it removed all my commits to do so.
g
try this on your branch 
git fetch origin main && git merge origin/main
it should detect conflicts
you need to fix them, then add all the files and continue with 
git merge --continue
sorry if I’m saying things you already know
j
you're fine,. its been 15 years and I still get myself into git corners I cant google out of 😄
g
I have alias for all these things 😅 that’s how I don’t forget
j
It doesnt help that im like 10 years into gitlab land at this point.
😄 1
OK, didnt need to do that 
git merge --continue
but getting it to let me resolve the conflicts locally and pushing back to my branch worked.
🙌 1
ok, Pull Req is back in business: https://github.com/runatlantis/helm-charts/pull/289
😎 1
p
ok, so we are good with this PR?
j
Yes
and thats with the added ci-values.yaml to include the ingress values
p
merged1
🙌 1
thank you both for the colaboration!!!
j
ugh, now i have to deploy oauth proxy and configure it to front atlantis lol
I had a good excuse that it wasnt ready until now
😆 1
p
lol
2 Views
Open in Slack
PreviousNext
Powered by