This message was deleted.
# atlantis-contributorss
Slackbot
03/21/2023, 1:47 AMThis message was deleted.
j
Justin S
03/21/2023, 1:50 AMThe index.yaml is updated with that version, but containing the wrong appVersion
https://github.com/runatlantis/helm-charts/blob/gh-pages/index.yaml#L5
p
PePe Amengual
03/21/2023, 5:30 AMahhh this is because we did not released 0.23.2 helm chart because it was a bug fix
PePe Amengual
03/21/2023, 5:30 AM@Dylan Page
j
Justin S
03/21/2023, 1:04 PMIm having trouble seeing the issue with the release stuff.
Ive never had to deal with the github actions before, but what you guys have, appears to be very similar to what Jenkins uses, and I have submitted a good amount of Pull Requests to them, created new charts and not hit issues.
Justin S
03/21/2023, 1:04 PMThe only difference I can even find, is you guys have a bit of filtering on your
on.pushJustin S
03/21/2023, 3:13 PMWhen someone looks at the helm chart stuff, id love to atleast know whats going on. I think my company is going to be able to start contributing alot of gitlab specific stuff so I want to make sure im not giving you all broken releases every time
p
PePe Amengual
03/21/2023, 4:55 PMthe github action auto increment the version, we just need to manually increment to match the real version with Atlantis
PePe Amengual
03/21/2023, 4:56 PMand then they will be in sync
PePe Amengual
03/21/2023, 4:56 PMwhen you say
I think my company is going to be able to start contributing alot of gitlabPePe Amengual
03/21/2023, 4:56 PMcode improvements to Gitlab VCS on atlantis?
j
Justin S
03/21/2023, 7:17 PMYes
Justin S
03/21/2023, 7:18 PMBut, the chart is still sitting there broken: https://github.com/runatlantis/helm-charts/tree/atlantis-4.12.1
Justin S
03/21/2023, 7:20 PMI cant do anything to fix that or I would.
p
PePe Amengual
03/21/2023, 7:23 PMwe will have to fix it
PePe Amengual
03/21/2023, 7:30 PMj
Justin S
03/21/2023, 7:31 PMI dont understand why the previous Pull Request Failed.
Justin S
03/21/2023, 7:31 PMApp Version, and Chart Version were bumped, both to correct values.
p
PePe Amengual
03/21/2023, 7:31 PMbut it was rerun on an existing tag
PePe Amengual
03/21/2023, 7:32 PMohhhh wait….no
j
Justin S
03/21/2023, 7:32 PMit was a brand new PR i made
p
PePe Amengual
03/21/2023, 7:32 PMit was not….
j
Justin S
03/21/2023, 7:32 PMp
PePe Amengual
03/21/2023, 7:32 PMyes it was yours
j
Justin S
03/21/2023, 7:32 PMBecause that new app version, has the gitlab fixes we got into it
p
PePe Amengual
03/21/2023, 7:33 PMlet me check
PePe Amengual
03/21/2023, 7:55 PMI can’t see why it did not work
PePe Amengual
03/21/2023, 7:55 PMthe github action is very simple
j
Justin S
03/21/2023, 7:55 PMi checked it against Jenkins, and they appeared very similar
Justin S
03/21/2023, 7:56 PMthe failure, looked like it already existed somehow
p
PePe Amengual
03/21/2023, 7:56 PMI guess the only thing could be the chart-releaser action was updated to the latest
PePe Amengual
03/21/2023, 8:02 PMI want to still try to merge my PR and see, the only thin I could thing if that the tag was created by hand before the release happened
PePe Amengual
03/21/2023, 8:13 PMmaybe this is the problem :https://github.com/helm/chart-releaser/pull/111
d
Dylan Page
03/22/2023, 3:15 PMSorry I was traveling yesterday. This is our exact issue: https://github.com/helm/chart-releaser-action/pull/80
Dylan Page
03/22/2023, 3:16 PMthe action does a git diff instead of checking chartVersion
p
PePe Amengual
03/22/2023, 3:39 PMmmm so it created the tag before checking basically?
PePe Amengual
03/22/2023, 3:40 PMI added the SKIP yesterday and it worked so I wonder what it does
d
Dylan Page
03/22/2023, 4:17 PMno it will only cut a new tag if it detects changes in the git diff
Dylan Page
03/22/2023, 4:18 PMhence why when we do no-op bumps it'll fail with "tag already exists" because it doesn't bump a new version
Dylan Page
03/22/2023, 4:18 PMkinda unimpressed with how flaky this action is
Dylan Page
03/22/2023, 4:18 PMmaybe we just do it ourselves