https://www.runatlantis.io/ logo
Title
j

Justin S

03/21/2023, 1:47 AM
The index.yaml is updated with that version, but containing the wrong appVersion https://github.com/runatlantis/helm-charts/blob/gh-pages/index.yaml#L5
p

PePe Amengual

03/21/2023, 5:30 AM
ahhh this is because we did not released 0.23.2 helm chart because it was a bug fix
@Dylan Page
j

Justin S

03/21/2023, 1:04 PM
Im having trouble seeing the issue with the release stuff. Ive never had to deal with the github actions before, but what you guys have, appears to be very similar to what Jenkins uses, and I have submitted a good amount of Pull Requests to them, created new charts and not hit issues.
The only difference I can even find, is you guys have a bit of filtering on your
on.push
and your version of helm is barely newer.
When someone looks at the helm chart stuff, id love to atleast know whats going on. I think my company is going to be able to start contributing alot of gitlab specific stuff so I want to make sure im not giving you all broken releases every time
p

PePe Amengual

03/21/2023, 4:55 PM
the github action auto increment the version, we just need to manually increment to match the real version with Atlantis
and then they will be in sync
when you say
I think my company is going to be able to start contributing alot of gitlab
what does this means?
code improvements to Gitlab VCS on atlantis?
j

Justin S

03/21/2023, 7:17 PM
Yes
But, the chart is still sitting there broken: https://github.com/runatlantis/helm-charts/tree/atlantis-4.12.1
I cant do anything to fix that or I would.
p

PePe Amengual

03/21/2023, 7:23 PM
we will have to fix it
j

Justin S

03/21/2023, 7:31 PM
I dont understand why the previous Pull Request Failed.
App Version, and Chart Version were bumped, both to correct values.
p

PePe Amengual

03/21/2023, 7:31 PM
but it was rerun on an existing tag
ohhhh wait….no
j

Justin S

03/21/2023, 7:32 PM
it was a brand new PR i made
p

PePe Amengual

03/21/2023, 7:32 PM
it was not….
p

PePe Amengual

03/21/2023, 7:32 PM
yes it was yours
j

Justin S

03/21/2023, 7:32 PM
Because that new app version, has the gitlab fixes we got into it
p

PePe Amengual

03/21/2023, 7:33 PM
let me check
I can’t see why it did not work
the github action is very simple
j

Justin S

03/21/2023, 7:55 PM
i checked it against Jenkins, and they appeared very similar
the failure, looked like it already existed somehow
p

PePe Amengual

03/21/2023, 7:56 PM
I guess the only thing could be the chart-releaser action was updated to the latest
I want to still try to merge my PR and see, the only thin I could thing if that the tag was created by hand before the release happened
d

Dylan Page

03/22/2023, 3:15 PM
Sorry I was traveling yesterday. This is our exact issue: https://github.com/helm/chart-releaser-action/pull/80
the action does a git diff instead of checking chartVersion
p

PePe Amengual

03/22/2023, 3:39 PM
mmm so it created the tag before checking basically?
I added the SKIP yesterday and it worked so I wonder what it does
d

Dylan Page

03/22/2023, 4:17 PM
no it will only cut a new tag if it detects changes in the git diff
hence why when we do no-op bumps it'll fail with "tag already exists" because it doesn't bump a new version
kinda unimpressed with how flaky this action is
maybe we just do it ourselves