https://www.runatlantis.io/ logo
Title
p

PePe Amengual

03/29/2023, 4:54 AM
@Isaac Wilson you mentioned gitlab and we are currently having a regresion after go-gitlab update and a PR that caused bad issues for gitlab users https://github.com/runatlantis/atlantis/issues/3258
👀 1
if you could help in that it will be great
i

Isaac Wilson

03/29/2023, 5:09 AM
Should we add a client version check (e.g.
g.Client.Version.GetVersion()
) and if version < 15.6 we can use the old logic?
p

PePe Amengual

03/29/2023, 5:10 AM
yes, that could work
i

Isaac Wilson

03/29/2023, 5:43 AM
I’ll open an MR PR in the morning
p

PePe Amengual

03/29/2023, 12:23 PM
nice
i

Isaac Wilson

03/29/2023, 7:55 PM
Could I get some eyes on my other one as well? https://github.com/runatlantis/atlantis/pull/3272
👀 1
p

PePe Amengual

03/29/2023, 11:13 PM
just two
😂 1
eyes