https://www.runatlantis.io/ logo
Title
d

Dylan Page

04/11/2023, 6:15 PM
Do you have a link to the issue?
b

Bruno Schaatsbergen

04/11/2023, 6:34 PM
^ the one that was raised recently by someone
and the one that should solve it (I believe) https://github.com/runatlantis/atlantis/issues/3268
d

Dylan Page

04/11/2023, 7:00 PM
yeah this is a mess
seems to be differences in GHE and GitHub Cloud API
are you get the same error in 3268 and have no branch protections setup Bruno?
b

Bruno Schaatsbergen

04/11/2023, 7:13 PM
Same as in 3320, with branch protection setup actually. I'll quickly disable it to see what happens
d

Dylan Page

04/11/2023, 7:16 PM
and this is on 0.23.4?
b

Bruno Schaatsbergen

04/11/2023, 7:16 PM
Yep, running 0.23.4
Without branch protection and with branch protection:
image.png
image.png
image.png
quick docker inspect yields the above ☝️
d

Dylan Page

04/11/2023, 7:30 PM
Yeah I can confirm that you cannot access the API branch permissions unless you have admin perms on the user/app
p

PePe Amengual

04/11/2023, 7:35 PM
is this only true for the app?
if you do it with the webhook is the same?
We should revert that PR or hide that option behind a flag and update the docs
it is causing too many issues and only works in some cases
d

Dylan Page

04/11/2023, 8:11 PM
It happens even if it is a user or an app
We should revert and they can re-submit the feature behind a flag
p

PePe Amengual

04/11/2023, 8:11 PM
yes
d

Dylan Page

04/11/2023, 8:11 PM
Its a breaking change otherwise
because asking everyone to change permissions is unacceptable
☝️ 1
p

PePe Amengual

04/11/2023, 8:12 PM
I agree
d

Dylan Page

04/11/2023, 8:12 PM
I'll setup the revert PR
🙌 1
p

PePe Amengual

04/11/2023, 8:14 PM
Thanks Dylan
d

Dylan Page

04/11/2023, 8:36 PM
p

PePe Amengual

04/11/2023, 8:37 PM
can we add something to the docs about the admin permissions?
d

Dylan Page

04/11/2023, 8:41 PM
It can be re-added in a later PR to re-introduce the feature
We're just reverting now
p

PePe Amengual

04/11/2023, 8:45 PM
ok
approved
d

Dylan Page

04/11/2023, 8:57 PM
@Bruno Schaatsbergen the dev image is building now, would you be able to test soon
I'm currently re-building my cluster
b

Bruno Schaatsbergen

04/11/2023, 9:48 PM
For sure!
:ty: 1
I suppose it's
<http://ghcr.io/runatlantis/atlantis:dev-debian-34ad9e9|ghcr.io/runatlantis/atlantis:dev-debian-34ad9e9>
?
p

PePe Amengual

04/11/2023, 9:57 PM
yes
we create an image per commit
👌 1
d

Dylan Page

04/11/2023, 10:02 PM
yeah
dev
and
dev-alpine
are the same
dev-debian
is available as well
b

Bruno Schaatsbergen

04/11/2023, 10:19 PM
Works 👍
👍 1
image.png
p

PePe Amengual

04/11/2023, 10:24 PM
awesome
r

RB

04/12/2023, 3:27 AM
Nice! Good idea to revert. Seemed to be causing issues. We should probably ping the original developer too
p

PePe Amengual

04/12/2023, 3:44 PM
we should do a release
d

Dylan Page

04/12/2023, 3:47 PM
I merged in the debian image fix as well
testing today after office hours
🙌 1