This message was deleted.
# atlantis-contributorss
Slackbot
04/11/2023, 6:15 PMThis message was deleted.
b
Bruno Schaatsbergen
04/11/2023, 6:34 PMBruno Schaatsbergen
04/11/2023, 6:34 PM^ the one that was raised recently by someone
Bruno Schaatsbergen
04/11/2023, 6:35 PMand the one that should solve it (I believe) https://github.com/runatlantis/atlantis/issues/3268
d
Dylan Page
04/11/2023, 7:00 PMyeah this is a mess
Dylan Page
04/11/2023, 7:00 PMseems to be differences in GHE and GitHub Cloud API
Dylan Page
04/11/2023, 7:01 PMare you get the same error in 3268 and have no branch protections setup Bruno?
b
Bruno Schaatsbergen
04/11/2023, 7:13 PMSame as in 3320, with branch protection setup actually. I'll quickly disable it to see what happens
d
Dylan Page
04/11/2023, 7:16 PMand this is on 0.23.4?
b
Bruno Schaatsbergen
04/11/2023, 7:16 PMYep, running 0.23.4
Bruno Schaatsbergen
04/11/2023, 7:16 PMWithout branch protection and with branch protection:
Bruno Schaatsbergen
04/11/2023, 7:19 PMquick docker inspect yields the above ☝️
d
Dylan Page
04/11/2023, 7:30 PMYeah I can confirm that you cannot access the API branch permissions unless you have admin perms on the user/app
p
PePe Amengual
04/11/2023, 7:35 PMis this only true for the app?
PePe Amengual
04/11/2023, 7:35 PMif you do it with the webhook is the same?
PePe Amengual
04/11/2023, 8:07 PMWe should revert that PR or hide that option behind a flag and update the docs
PePe Amengual
04/11/2023, 8:09 PMit is causing too many issues and only works in some cases
d
Dylan Page
04/11/2023, 8:11 PMIt happens even if it is a user or an app
Dylan Page
04/11/2023, 8:11 PMWe should revert and they can re-submit the feature behind a flag
p
PePe Amengual
04/11/2023, 8:11 PMyes
d
Dylan Page
04/11/2023, 8:11 PMIts a breaking change otherwise
Dylan Page
04/11/2023, 8:11 PMbecause asking everyone to change permissions is unacceptable
☝️ 1
p
PePe Amengual
04/11/2023, 8:12 PMI agree
d
Dylan Page
04/11/2023, 8:12 PMI'll setup the revert PR
🙌 1
p
PePe Amengual
04/11/2023, 8:14 PMThanks Dylan
d
Dylan Page
04/11/2023, 8:36 PMp
PePe Amengual
04/11/2023, 8:37 PMcan we add something to the docs about the admin permissions?
d
Dylan Page
04/11/2023, 8:41 PMIt can be re-added in a later PR to re-introduce the feature
Dylan Page
04/11/2023, 8:41 PMWe're just reverting now
p
PePe Amengual
04/11/2023, 8:45 PMok
PePe Amengual
04/11/2023, 8:46 PM✅ approved
d
Dylan Page
04/11/2023, 8:57 PM@Bruno Schaatsbergen the dev image is building now, would you be able to test soon
Dylan Page
04/11/2023, 8:57 PMI'm currently re-building my cluster
b
Bruno Schaatsbergen
04/11/2023, 9:48 PMFor sure!
ty 1
Bruno Schaatsbergen
04/11/2023, 9:54 PMI suppose it's
<http://ghcr.io/runatlantis/atlantis:dev-debian-34ad9e9|ghcr.io/runatlantis/atlantis:dev-debian-34ad9e9>p
PePe Amengual
04/11/2023, 9:57 PMyes
PePe Amengual
04/11/2023, 9:57 PMwe create an image per commit
👌 1
d
Dylan Page
04/11/2023, 10:02 PMyeah
devdev-alpineDylan Page
04/11/2023, 10:02 PMdev-debianb
Bruno Schaatsbergen
04/11/2023, 10:19 PMWorks 👍
👍 1
p
PePe Amengual
04/11/2023, 10:24 PMawesome
r
RB
04/12/2023, 3:27 AMNice! Good idea to revert. Seemed to be causing issues. We should probably ping the original developer too
p
PePe Amengual
04/12/2023, 3:44 PMwe should do a release
d
Dylan Page
04/12/2023, 3:47 PMI merged in the debian image fix as well
Dylan Page
04/12/2023, 3:47 PMtesting today after office hours
🙌 1