Do you have a link to the issue

Question

Bruno Schaatsbergen · Answer

Bruno Schaatsbergen · Answer

^ the one that was raised recently by someone

Bruno Schaatsbergen · Answer

and the one that should solve it I believe <https github com runatlantis atlantis issues 3268>

Dylan Page · Answer

yeah this is a mess

Dylan Page · Answer

seems to be differences in GHE and GitHub Cloud API

Dylan Page · Answer

are you get the same error in 3268 and have no branch protections setup Bruno

Bruno Schaatsbergen · Answer

Same as in 3320 with branch protection setup actually I ll quickly disable it to see what happens

Dylan Page · Answer

and this is on 0 23 4

Bruno Schaatsbergen · Answer

Yep running 0 23 4

Bruno Schaatsbergen · Answer

Without branch protection and with branch protection

Bruno Schaatsbergen · Answer

image png

Bruno Schaatsbergen · Answer

image png

Bruno Schaatsbergen · Answer

image png

Bruno Schaatsbergen · Answer

quick docker inspect yields the above point up

Dylan Page · Answer

Yeah I can confirm that you cannot access the API branch permissions unless you have admin perms on the user app

PePe Amengual · Answer

is this only true for the app

PePe Amengual · Answer

if you do it with the webhook is the same

PePe Amengual · Answer

We should revert that PR or hide that option behind a flag and update the docs

PePe Amengual · Answer

it is causing too many issues and only works in some cases

Dylan Page · Answer

It happens even if it is a user or an app

Dylan Page · Answer

We should revert and they can re submit the feature behind a flag

PePe Amengual · Answer

yes

Dylan Page · Answer

Its a breaking change otherwise

Dylan Page · Answer

because asking everyone to change permissions is unacceptable

PePe Amengual · Answer

I agree

Dylan Page · Answer

I ll setup the revert PR

PePe Amengual · Answer

Thanks Dylan

Dylan Page · Answer

PePe Amengual · Answer

can we add something to the docs about the admin permissions

Dylan Page · Answer

It can be re added in a later PR to re introduce the feature

Dylan Page · Answer

We re just reverting now

PePe Amengual · Answer

ok

PePe Amengual · Answer

white check mark approved

Dylan Page · Answer

< Bruno Schaatsbergen> the dev image is building now would you be able to test soon

Dylan Page · Answer

I m currently re building my cluster

Bruno Schaatsbergen · Answer

For sure

Bruno Schaatsbergen · Answer

I suppose it s `<http ghcr io runatlantis atlantis dev debian 34ad9e9|ghcr io runatlantis atlantis dev debian 34ad9e9>`

PePe Amengual · Answer

yes

PePe Amengual · Answer

we create an image per commit

Dylan Page · Answer

yeah `dev` and `dev alpine` are the same

Dylan Page · Answer

`dev debian` is available as well

Bruno Schaatsbergen · Answer

Works +1

Bruno Schaatsbergen · Answer

image png

PePe Amengual · Answer

awesome

RB · Answer

Nice Good idea to revert Seemed to be causing issues We should probably ping the original developer too

PePe Amengual · Answer

we should do a release

Dylan Page · Answer

I merged in the debian image fix as well

Dylan Page · Answer

testing today after office hours