Marcus Ramberg

05/05/2023, 4:40 PM
@RB I’m a bit confused by your last comment - isn’t this test from the previous reaction PR basically the same as TestPost_GithubCommentResponse?


05/05/2023, 4:45 PM
These are just suggestions, it's possible that i missed that
The goal is to make sure the lines of additional code is fully tested. If that's true, then please link to that in the pr
👍 1

Marcus Ramberg

05/05/2023, 4:56 PM
Sure. I’m also in favor of having good tests 🙂 tbh I think it would be interesting to look into a more end to end test that only mocked the http responses from github rather than mocking all the model methods / parsing like our current event controller tests do, but that’s a bigger task.