@RB I’m a bit confused by your last comment - https://github.com/runatlantis/atlantis/blob/41310bf8d1a0ea2426ed38a52cf0ef275b2927d6/server/controllers/events/events_controller_test.go#L386 isn’t this test from the previous reaction PR basically the same as TestPost_GithubCommentResponse?

These are just suggestions, it's possible that i missed that

Sure. I’m also in favor of having good tests 🙂 tbh I think it would be interesting to look into a more end to end test that only mocked the http responses from github rather than mocking all the model methods / parsing like our current event controller tests do, but that’s a bigger task.

We have these that run on every pr https://github.com/runatlantis/atlantis/blob/41310bf8d1a0ea2426ed38a52cf0ef275b2927d6/server/controllers/events/events_controller_e2e_test.go