This message was deleted.
# atlantis-contributorss
Slackbot
05/05/2023, 4:40 PMThis message was deleted.
r
RB
05/05/2023, 4:45 PMThese are just suggestions, it's possible that i missed that
RB
05/05/2023, 4:46 PMThe goal is to make sure the lines of additional code is fully tested. If that's true, then please link to that in the pr
👍 1
m
Marcus Ramberg
05/05/2023, 4:56 PMSure. I’m also in favor of having good tests 🙂 tbh I think it would be interesting to look into a more end to end test that only mocked the http responses from github rather than mocking all the model methods / parsing like our current event controller tests do, but that’s a bigger task.
r
RB
05/05/2023, 5:30 PMWe have these that run on every pr
https://github.com/runatlantis/atlantis/blob/41310bf8d1a0ea2426ed38a52cf0ef275b2927d6/server/controllers/events/events_controller_e2e_test.go
🚀 1