https://www.runatlantis.io/ logo
Join Slack
Powered by
This message was deleted.
# atlantis-community
s
This message was deleted.
y
running 
v0.23.3
p
does the Atlantis user have permissions to comments?
y
this is what it has, I think so?
p
seems right
t
Could be one of these conditions causing it to continue before minimizing
Copy code
!strings.Contains(firstLine, strings.ToLower(command)) 

comment.User != nil && !strings.EqualFold(comment.User.GetLogin(), g.user)

len(body) == 0
Seems like the only one that might be doing it is the second one, where the user configured on atlantis side doesn't match the commented username
It will also only hide the subsequent command of the same type, i.e. plan hides plan
p
atlantis will hide any of it’s own comments
y
hmm yeah it’s definitely a comment by atlantis. I’m using a GitHub App so it’s got its own name and is marked 
bot
.
i don’t think there’s anything particularly unique about my setup…? Private github org, github app installed into the org and enabled for just this repo, using terragrunt. Atlantis is using ephemeral disk but it hasn’t restarted recently
p
if you try in a personal repo for example?
y
It was located in my personal repo earlier. It also didn’t collapse comments but I assumed it was because I kept restarting it
Repo’s been deleted now 😕
Restarts shouldn’t effect it looking at those conditionals @Tyler Allen posted right?
p
you need at least two comments for atlantis to collapse one
y
yeah, i’ve got exactly two comments. Both expanded
Also, I assume this log line means Atlantis thinks it successfully collapsed a comment?
Copy code
{"name":"atlantis.github.hide_prev_plan_comments.execution_success","value":1,
p
you have debug enabled?
y
Copy code
{"level":"debug",
^ i have that in the logs, left the defaults
yeah, i have 
ATLANTIS_LOG_LEVEL=debug
oh that’s super weird. I think that log line means atlantis (thinks it) successfully called github to hide a comment… but no comment was hidden https://github.com/runatlantis/atlantis/blob/fd1ce4328dcc160e9375afb74722be530809a8e8/server/events/vcs/instrumented_client.go#L131
p
did you tried more than 2 times?
running atlantis plan?
y
Just ran it again. Now I have 3 not hidden comments from Atlantis in the PR…
p
It works fine for me in ECS
but I wonder if maybe is a permissions issue still
can you try give admin? and see
e
wasn’t there an issue with hiding comments and github app name
y
oooo, that looks like it could be the issue
my github app has a space in it and so i’m gonna have to get an admin to rename it…
p
Ed is right, that will do it
Open in Slack
PreviousNext
Powered by