hello, I can’t seem to get Atlantis to hide previous comments. It’s deployed using the ECS fargate terraform module, and I checked that it has the

ATLANTIS_HIDE_PREV_PLAN_COMMENTS=true

environment variable set. Pasted some debug logs that said the

atlantis.github.hide_prev_plan_comments.execution_success

counter got ticked up. But the previous comment isn’t being hidden. Any idea what might the problem be?

does the Atlantis user have permissions to comments?

this is what it has, I think so?

seems right

Could be one of these conditions causing it to continue before minimizing

!strings.Contains(firstLine, strings.ToLower(command)) 

comment.User != nil && !strings.EqualFold(comment.User.GetLogin(), g.user)

len(body) == 0

Seems like the only one that might be doing it is the second one, where the user configured on atlantis side doesn't match the commented username

atlantis will hide any of it’s own comments

hmm yeah it’s definitely a comment by atlantis. I’m using a GitHub App so it’s got its own name and is marked

bot

.

if you try in a personal repo for example?

It was located in my personal repo earlier. It also didn’t collapse comments but I assumed it was because I kept restarting it

you need at least two comments for atlantis to collapse one

yeah, i’ve got exactly two comments. Both expanded

you have debug enabled?

{"level":"debug",

^ i have that in the logs, left the defaults

did you tried more than 2 times?

Just ran it again. Now I have 3 not hidden comments from Atlantis in the PR…

It works fine for me in ECS

wasn’t there an issue with hiding comments and github app name

oooo, that looks like it could be the issue

Ed is right, that will do it