:wave: Hello, I have discovered some bugs in the K...
# dev
j
👋 Hello, I have discovered some bugs in the Kafka Connect Adaptor and one in particular is currently blocking our adoption of Pulsar (https://github.com/apache/pulsar-connectors/issues/30). The fix is quite simple, so I have already prepared one with breaking changes for the next major release (PR link). I would be happy to also prepare a backward compatible fix for the older versions. I would mainly like to know whether the maintainers are comfortable with the proposed approach. Also, I do not want to sound pushy, but since this issue is blocking our adoption and we may otherwise need to choose a different solution, I would appreciate any indication of the likelihood that someone could review it before the next major release or earlier fix releases. It would help us a lot to know as early as possible. Thank you
l
Thanks for the report and volunteering to fix the issue. I provided some feedback on the issue and the PR. Since connectors are separate from the Pulsar distribution itself, you could also compile a patched version yourself and use it before a Pulsar release contains the fix.
j
Thanks for quick feedback
Hi @Lari Hotari, I just wanted to check whether you have had a chance to look at the PR. Thank you
l
I'm sorry I'm busy with 5.0.0-M1 release. I'll check once that's done.
gratitude thank you 1
j
Hi @Lari Hotari, sorry to disturb again. Just wanted to check if you got chance to look at it. Thank you
l
I'm sorry that I've been busy with multiple Pulsar releases and now I'm going on PTO. @David K do you have a chance to review Jarek's PR? PR: github.com/apache/pulsar-connectors/pull/31 Issue: github.com/apache/pulsar-connectors/issues/30
✅ 1
d
@Jarek I added a review and a unit test to your release branch. PTAL at items #3 and #4. Thanks!
j
Hello @David K, thank you for the feedback. I have answered you in the PR.
🙏 1