This message was deleted.
# general
s
This message was deleted.
m
instead of passing
<persistent://public/default/example-partition-0>
, pass it as
<persistent://public/default/example>
and try.
u
All print
false
, still confusing.
l
yes, this is confusing. There are 2 related concepts. In this example, the "partitioned topic" is
<persistent://public/default/example>
and the "topic partition" is
<persistent://public/default/example-partition-0>
. The current documentation could be improved to reduce the confusion.
a
If there’s one thing I would rename / re-architect (have no idea how) is that exact confusion and terminology.
👀 1
👍 2
u
This terminology is quite basic concept in pulsar, it would be great if get improved.
j
@萧易客 May I ask for URL you got the example from? Trying to see what we can do about it.
l
@JooHyukKim We have been discussing that the Javadoc of isPartitioned and getPartitionedTopicName methods in TopicName class should be improved. https://github.com/apache/pulsar/blob/8e0ebba345f5f02bf2434fec9a75268d92b1b60d/pul[…]on/src/main/java/org/apache/pulsar/common/naming/TopicName.java
🎉 1
@JooHyukKim in addition, there doesn't seem to be a good definition of what a "partitioned topic" and a "non-partitioned topic" really means. There are docs about "topics" in https://pulsar.apache.org/docs/3.0.x/concepts-messaging/#topics and "partitioned topics" in https://pulsar.apache.org/docs/3.0.x/concepts-messaging/#partitioned-topics , however, this could be confusing for a person that doesn't have previous knowledge about Pulsar.
in the "partitioned topics" doc, it says "A partitioned topic is implemented as N internal topics," . This uses the concept of an "internal topic". It would be useful if there would be a consistent glossary about the concepts. Concepts should include whatever is commonly used when talking about Pulsar concepts. For example, I commonly call each of these "internal topics" a "topic partition". I don't know if that's what others do, but something like an "internal topic" is not a very good concept. I'm not sure what others have to say about this.
j
@Lari Hotari Thank you for the detailed explanation🙏🏼🙏🏼 I was going to reply back in this thread, but due to the volume, decided to create a Github Issue later today. I will link the issue here once I open it
l
It might be useful to have a broader discussion on the mailing list about the concepts. btw. I noticed that there is a "Pulsar Terminology" section in the docs, https://pulsar.apache.org/docs/3.0.x/reference-terminology/ . This isn't consistent with the other parts of the docs. The explanations aren't sufficient. For example, it says: "Partitioned Topic: A topic that is served by multiple Pulsar brokers, which enables higher throughput".
j
It might be useful to have a broader discussion on the mailing list about the concepts.
@Lari Hotari May I ask which mailing list you’re refering to? Is it one of those in the 🔗 website ?
l
The Developer mailing list has a more active audience. We do also have a user mailing list, but there's hardly any activity there.
j
Thanksss coming up soon.
Created an issue on GitHub to get a new discussion appeared on mailing list 🤔. I am not sure if done right.
m
This has even been the source of recently discovered bugs.
Thanks for starting the discussion @JooHyukKim
j
This has even been the source of recently discovered bugs.
Such confusion creates bug in most cases 🥲 At least we managed put it out there exposed.
Thanks for starting the discussion
No problem! @Michael Marshall 👍🏻 Maybe stop by to drop a word or two when there is spare time? 😆