Hi, I'm planning to remove the support for legacy padding character

'%'

which can cause unnecessary overhead, and complicates the code. We have enforced the padding to be

'\0'

about 5 years ago in this PR, so this change can only affect the very early user of Pinot (probably only LinkedIn). @Sidd @Subbu Subramaniam Let me know if you have concern on this

Am I right in stating that the only way this can break is if there is a segment that has been created more than 5 years ago (and never updated), and explicitly used the

%

padding character?

Yes correct

We did find old segments that had no setting of

segment.padding.char

and therefore defaults to

%

according to code. We are figuring out the best way to move forward. Please hold off a bit.

@Subbu Subramaniam and @Jackie We are done with the cleanup from our side. We can go ahead with this PR.

thanks, vivek

Thanks @Vivek Iyer Vaidyanathan. Do you want to help review it since you already know the context?

Sure, I can help with the review.