Folks, while running the tests on 0.11.0 rc branch, I see failures like: [

INFO] Running org.apache.pinot.segment.spi.creator.IndexingOverridesTest

21:59:54.364 [main] ERROR org.apache.pinot.segment.spi.index.IndexingOverrides - could not construct MethodHandle for org.apache.pinot.segment.local.segment.creator.impl.DefaultIndexCreatorProvider

java.lang.ClassNotFoundException: org.apache.pinot.segment.local.segment.creator.impl.DefaultIndexCreatorProvider

at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) ~[?:?]

at jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) ~[?:?]

at java.lang.ClassLoader.loadClass(ClassLoader.java:522) ~[?:?]

at java.lang.Class.forName0(Native Method) ~[?:?]

at java.lang.Class.forName(Class.java:398) ~[?:?]

at org.apache.pinot.segment.spi.index.IndexingOverrides.invokeDefaultConstructor(IndexingOverrides.java:131) [classes/:?]

at org.apache.pinot.segment.spi.index.IndexingOverrides.createDefaultCreatorProvider(IndexingOverrides.java:116) [classes/:?]

at org.apache.pinot.segment.spi.index.IndexingOverrides.<clinit>(IndexingOverrides.java:67) [classes/:?]

at org.apache.pinot.segment.spi.creator.IndexingOverridesTest.indexingOverridesLoadableWithoutDefaultImplementation(IndexingOverridesTest.java:40) [test-classes/:?]

at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]

at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]

at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]

at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]

at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:108) [testng-6.11.jar:?]

at org.testng.internal.Invoker.invokeMethod(Invoker.java:661) [testng-6.11.jar:?]

at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:869) [testng-6.11.jar:?]

at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1193) [testng-6.11.jar:?]

at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:126) [testng-6.11.jar:?]

at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109) [testng-6.11.jar:?]

at org.testng.TestRunner.privateRun(TestRunner.java:744) [testng-6.11.jar:?]

at org.testng.TestRunner.run(TestRunner.java:602) [testng-6.11.jar:?]

at org.testng.SuiteRunner.runTest(SuiteRunner.java:380) [testng-6.11.jar:?]

at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:375) [testng-6.11.jar:?]

at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340) [testng-6.11.jar:?]

at org.testng.SuiteRunner.run(SuiteRunner.java:289) [testng-6.11.jar:?]

at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) [testng-6.11.jar:?]

at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86) [testng-6.11.jar:?]

at org.testng.TestNG.runSuitesSequentially(TestNG.java:1301) [testng-6.11.jar:?]

at org.testng.TestNG.runSuitesLocally(TestNG.java:1226) [testng-6.11.jar:?]

at org.testng.TestNG.runSuites(TestNG.java:1144) [testng-6.11.jar:?]

at org.testng.TestNG.run(TestNG.java:1115) [testng-6.11.jar:?]

at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:136) [surefire-testng-3.0.0-M5.jar:3.0.0-M5]

at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:112) [surefire-testng-3.0.0-M5.jar:3.0.0-M5]

at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:99) [surefire-testng-3.0.0-M5.jar:3.0.0-M5]

at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:145) [surefire-testng-3.0.0-M5.jar:3.0.0-M5]

at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428) [surefire-booter-3.0.0-M5.jar:3.0.0-M5]

at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) [surefire-booter-3.0.0-M5.jar:3.0.0-M5]

at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562) [surefire-booter-3.0.0-M5.jar:3.0.0-M5]

at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548) [surefire-booter-3.0.0-M5.jar:3.0.0-M5]

which commit was this on?

that's not a test failure, it's verifying that even if that exception is thrown (because the classpath excludes the default implementation for some reason) registering an override still works