For presto fix, you need to make sure the Pom file changes for pinot-spi, pinot-common, etc modules are also reflected in pinot-spi-jdk8, pinot-common-jdk8
Xiang Fu
05/06/2022, 2:54 AM
Those modules are under pinot-connectors/prestodb-pinot-dependencies
k
Kevin Xu
05/06/2022, 3:12 AM
@User Thanks for your prompt reply, Do you mean If I just add one dependency in pinot-common, I have to add this dependency to pinot-common-jdk8 pom file?
x
Xiang Fu
05/06/2022, 3:26 AM
yes
Xiang Fu
05/06/2022, 3:26 AM
We made sim link for source code
Xiang Fu
05/06/2022, 3:26 AM
But not Pom file
Xiang Fu
05/06/2022, 3:27 AM
So you need to make dependency aligned from both side
👍 1
Xiang Fu
05/06/2022, 3:27 AM
We saw this issue when try to release for both jdk8 and jdk11