Wanna wait for CI on this one - or force the merge...
# pinot-deva
Alexander Pucher
06/04/2020, 6:18 PMWanna wait for CI on this one - or force the merge right away?
m
Mayank
06/04/2020, 6:19 PM
If it is form
git reveta
Alexander Pucher
06/04/2020, 6:21 PMIt is. I’ll wait for a few min for dissenting voices, if any :)
s
Subbu Subramaniam
06/04/2020, 6:27 PMif u r sure this is commit just merge it reverting cant be bad since this is a very recent commit
Subbu Subramaniam
06/04/2020, 6:28 PMi would suggest starting a monthly job on master after revert. The only way I know to do this is to remve the existing monthy job, and add a new one. Just dont touch the daily job please
a
Alexander Pucher
06/04/2020, 6:32 PMIf you’re okay with it, I’ll leave this to you. 😄 I haven’t touched pinot travis in years an I’d rather not mess that one up
s
Subbu Subramaniam
06/04/2020, 7:04 PMhas it been merged?
a
Alexander Pucher
06/04/2020, 7:21 PMall merged. CI passed
m
Mayank
06/04/2020, 7:29 PM
Great, thanks. Will let you debug this async.
a
Alexander Pucher
06/04/2020, 7:30 PMunlikely that my PR changed anything of significance. I’d run a full test of the existing master - i.e. with all tests