In Eclipse I’ve pulled in all of the pinot project...
# pinot-dev
k
In Eclipse I’ve pulled in all of the pinot projects from
master
, and
pinot-segment-local
has an error. The ReplicationUtils class isn’t in the correct package (file says
org.apache.pinot.core.util
, but location in project is
org.apache.pinot.segment.local.utils
. See https://github.com/apache/incubator-pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/ReplicationUtils.java in GitHub
This
pinot-segment-local
sub-project is used by other Pinot sub-projects, otherwise I’d assume it’s vestigial. Or is my source tree somehow messed up?
m
The
pinot-segment-local
module was a big refactor a month or so ago. I am guessing Eclipse wasn't able to handle the refactor incrementally?
k
I had to import that sub-project explicitly, so it wasn’t a refactor in the IDE. Also note that the file in GitHub seems to have the wrong package, given where it’s located in the source tree.
m
You are right. Wow, how wasn't this caught, and how does the build work now?
Let me file a PR
Apparently, a class can be sitting in a wrong package and can still compile as long as it does not have any local dependencies.