Hi Pinot devs, I’ve finished this issue https://github.com/apache/pinot/issues/7309 to clean up our code repo to reformat the code and fix the checkstyle errors and enabled checkstyle maven plugin. There are a few slight changes of the coding style, please re-import the intellij checkstyle xml file. Still working on eclipse xml.

Hi @User - I just pulled from pinot master and tried to build. I got:

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:53 min (Wall Clock)
[INFO] Finished at: 2021-08-25T15:44:48-07:00
[INFO] Final Memory: 169M/898M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (checkstyle) on project pinot-broker: You have 2 Checkstyle violations. -> [Help 1]

But what’s odd is if I run

mvn checkstyle:checkstyle

from inside of the

pinot-broker

directory, it reports no errors. And I don’t see any error reported when building pinot-broker in the build output. I do see things like

[WARNING] checkstyle:check violations detected but failOnViolation set to false
[INFO] You have 252 Checkstyle violations.

in the build log for

pinot-tools

have you ran mvn clean then it?

I ran

mvn clean install -DskipTests -Pbin-dist -T 4 -Djdk.version=8

from the top when I hit this problem, yes